This repository has been archived by the owner on Feb 22, 2020. It is now read-only.
Fixed memory leak for Packet reader & writer #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PacketReader and PacketWriter didn't delete the allocated buffer properly causing a memory leak.
jskorpan
pushed a commit
that referenced
this pull request
May 12, 2014
Fixed memory leak for Packet reader & writer
|
Potentially causing a memory leak. I've done great many load tests with this piece of software on both Window and Linux and have yet failed to either see by myself any leaks or have had any such reports brought to my attention over the close to 3 year lifespan of the project. Given that, you are still technically right which I guess is the best kind of right :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PacketReader and PacketWriter didn't delete the allocated buffer
properly causing a memory leak.