Fix issue#20, bad handshake. #30
Conversation
…truction to fix it. Signed-off-by: Xiaolan.Lee <[email protected]>
|
Can't bring in GPL:ed code I'm afraid. Our code is BSD. Sorry On 14 apr 2013, at 04:04, "LeeXiaolan" <[email protected]mailto:[email protected]> wrote: This issue is caused by old password using, but no diagnosis information gives out. You can merge this Pull Request by running git pull https://github.com/LeeXiaolan/ultramysql master Or view, comment on, or merge it at: Commit Summary
File Changes
Patch Links: |
|
Ok I’ll take a look at it shortly, thanks! From: Xiaolan.Lee [mailto:[email protected]] Just merge fdb8b31fdb8b31, it is not gpl code. — |
| @@ -521,6 +521,12 @@ bool Connection::connect(const char *_host, int _port, const char *_username, co | |||
| m_dbgMethodProgress --; | |||
| return false; | |||
| } | |||
| if (result == 0xfe) | |||
| { | |||
| setError ("You are using old password, please update it use PASSWORD(), other than OLD_PASSWORD().", 4, UME_OTHER); | |||
There was a problem hiding this comment.
I think we could improve the clarity of this message.
Also
How can we be sure that result 0xfe really means this and only this?
//JT
There was a problem hiding this comment.
There was a problem hiding this comment.
Understood, merging it on friday!
Thanks for the contribution.
//JT
On 20 apr 2013, at 03:50, "Xiaolan.Lee" <[email protected]mailto:[email protected]> wrote:
In lib/Connection.cpp:
@@ -521,6 +521,12 @@ bool Connection::connect(const char *_host, int _port, const char *_username, co
m_dbgMethodProgress --;
return false;
}
- if (result == 0xfe)
- {
- setError ("You are using old password, please update it use PASSWORD(), other than OLD_PASSWORD().", 4, UME_OTHER);
Check out http://dev.mysql.com/doc/internals/en/connection-phase.html#packet-Protocol::AuthSwitchResponse and http://dev.mysql.com/doc/internals/en/connection-phase.htm#packet-Protocol::OldAuthSwitchRequest
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/30/files#r3884175.
Fix issue#20, bad handshake.
|
Can we add a test to the test suite to improve the test coverage? |
This issue is caused by old password using, but no diagnosis information gives out.