Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 751 #859

Closed
wants to merge 2 commits into from
Closed

Issue 751 #859

wants to merge 2 commits into from

Commits on Apr 19, 2019

  1. delay tearing down tcp control connections 

    The TEST_END message is racing with the server_timer_proc timer.
When the RTT is higher than a second, the timer wins the race
and closes the control socket before the results are exchanged.

This results in the client reporting:
"error - control socket has closed unexpectedly"
as reported in GH issue 751.

This change doesn't prevent the race, but significantly increases the
grace period based on a maximum RTT of 4 seconds and accounts for
the ten transitions in the iperf3 state machine.
    @acooks
    acooks committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    34bdddb View commit details
    Browse the repository at this point in the history

  2. let server cleanup after IPERF_DONE message 

    When the server receives IPERF_DONE, clean up and close the
control socket, instead of waiting for the test timer to expire.
    @acooks
    acooks committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    929f88a View commit details
    Browse the repository at this point in the history