Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved iperf_udp_recv() debug messages #1797

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

davidBar-On
Copy link
Contributor

  • Version of iperf3 (or development branch, such as master or
    3.1-STABLE) to which this pull request applies:
    master

  • Issues fixed (if any): none

  • Brief description of code changes (suitable for use as a commit message):

  • While trying to help with issue udp packet loss when there is active display server (xorg-server-1.20.14) on remote host #1793, I made the changes here in iperf_udp_recv() and I submit them as they may be useful in other cases. The main changes are changing the debug level of the LOST and REORDER messages to INFO (3) and adding debug message.

@bmah888
Copy link
Contributor

bmah888 commented Jan 6, 2025

Thanks for the PR! This seems like a good idea.

@bmah888 bmah888 self-assigned this Feb 6, 2025
Copy link
Contributor

@bmah888 bmah888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just one minor nit-pick and I'm good to merge this. I agree the added debugging messages (and debug levels) will be useful for debugging.

src/iperf_udp.c Outdated Show resolved Hide resolved
Copy link
Contributor

@bmah888 bmah888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, briefly run-tested.

@bmah888 bmah888 merged commit d8af312 into esnet:master Feb 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants