Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make status optional in ESMF_FieldEmptyReset() #324

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Make status optional in ESMF_FieldEmptyReset() #324

merged 2 commits into from
Nov 22, 2024

Conversation

theurich
Copy link
Member

@oehmke the new ESMF_FieldEmptyReset() looks good to me. Only thing I was thinking would be nice is to make the status argument optional. This is what this PR does.

@theurich theurich requested a review from oehmke November 22, 2024 18:17
oehmke
oehmke approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@oehmke oehmke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing! The changes that you suggest look good to me. I like the idea of making status optional.

@theurich theurich merged commit a184c8c into develop Nov 22, 2024
6 checks passed
@theurich theurich deleted the feature/field-empty-reset branch November 22, 2024 19:47
@theurich theurich self-assigned this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oehmke oehmke oehmke approved these changes

Assignees

@theurich theurich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theurich @oehmke