Bug fix for corner detection with tripolar grids #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of @russfiedler's fixes to the logic for detecting corners in tripolar grids when the corners are located at the tripole.
The previous faulty logic caused
ESMF_RegridWeightGen
(in ESMF 8.0.1) to fail when generating conservative remapping weights with tripolar grids at particular core counts.Relevant PET*.Log files contained
The code changes in this PR fix this issue.
For more details see COSIMA/access-om2#216 (comment)