Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade @eslint/core and @eslint/plugin-kit #315

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

fasttime
Copy link
Member

This PR promotes @eslint/core to a runtime dependency and upgrades @eslint/core and @eslint/plugin-kit to the latest versions.

This change ensures that @eslint/markdown will be used with a compatible version of @eslint/core in dependent packages even if the core types are changed in a breaking way in the future. This will help avoiding bugs like #313 where the removal of a type from @eslint/[email protected] to @eslint/[email protected] was causing the TS build to fail. Since @eslint/core was defined in the devDependencies, npm would not check its version range when @eslint/markdown was itself installed as a dependency.

I also made a change to the tsconfig.json in the type tests because I noticed that some files in the dist directory were not being checked.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit b8572cc into main Jan 17, 2025
15 checks passed
@mdjermanovic mdjermanovic deleted the upgrade-rewrite-deps branch January 17, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants