-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: added tests for options normalize #439
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there might be some overlap with some existing tests here and we'll probably want to colocate them so that they're easier to keep track of. That being said, I'm not against adding a test/lib/options.js
file and having it be a centralized location for all options tests!
@kaicataldo I agree I think there are 1-2 tests doing similar but in option testing, I am doing unit test for normalize method instead of running the whole parser. yes, it's not to strong as under the hood, its the same. let me know |
I'm not against unit testing this module, but I do think there's a lot more value in doing a more integration-style test at the parser level. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment, but otherwise this LGTM. I do think there's value in adding some more integration-style tests at the parser level, but it certainly doesn't hurt to have some unit tests here!
Co-Authored-By: Kai Cataldo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Thanks for contributing! |
added tests for
lib/options.js