Fix: a failing test with acorn 6.2.0 #416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mysticatea
force-pushed
the
fix-test-failure
branch
from
59b29a3 to
c92c756
Compare
kaicataldo
approved these changes
Jul 25, 2019
platinumazure
approved these changes
Jul 25, 2019
aladdin-add
approved these changes
Jul 26, 2019
|
I think I agree that we should upgrade the acorn dependency here- otherwise, merging this will cause tests to start failing for anyone with acorn@<6.2.0. @mysticatea Any concerns? |
|
@mysticatea Is this still needed now that #415 is merged? I'm thinking maybe this is no longer needed. |
|
No. I'm sorry that I have lost this issue... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a failing test case that is caused by the acorn update.
for (const a = 0 of b) ;should be a syntax error.