New: Add u and y regex flags (refs #10) #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzakas
force-pushed
the
regexflags
branch
2 times, most recently
from
4561ab9 to
b63df3b
Compare
|
Okay, finally got all the tests working. Definitely need to pull apart the test system, it's quite circuitous and hard to figure out what is causing certain things to go wrong. |
nzakas
added a commit
that referenced
this pull request
Dec 16, 2014
New: Add u and y regex flags (refs #10)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking for some feedback.
The tests are failing because I had to add the missing
regexproperty to both AST nodes and tokens when they represent a regular expression. This is becausevalueis unreliable given that Node.js doesn't support either flag, meaning we can't create a newRegExpto assign tovalue. Theregexproperty is already in Esprima Harmony, I just ported it over.The failing tests are those of the third-party JS libraries that Esprima uses to test AST output. I haven't had the time to convert those as they are massive.
Also, I found a bug where
tokenize()wasn't respecting theecmascriptsetting. That's fixed in this commit.