Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-config-eslint breaks the build #231

Closed
alberto opened this issue Jan 18, 2016 · 9 comments
Closed

eslint-config-eslint breaks the build #231

alberto opened this issue Jan 18, 2016 · 9 comments

Comments

@alberto
Copy link
Member

alberto commented Jan 18, 2016

Related to eslint/eslint#4909

@btmills
Copy link
Member

btmills commented Jan 18, 2016

@alberto what are you seeing? I just pulled master, npm install, npm test, and everything passed. What happens if you rm -rf node_modules/ && npm i?

@alberto
Copy link
Member Author

alberto commented Jan 18, 2016

Everything passes on my machine too, but it fails on travis. I forgot to link the related espree issue, see #230

@gyandeeps
Copy link
Member

I expect it too fail as travis is reporting.
Are you guys using node@5?

@alberto
Copy link
Member Author

alberto commented Jan 18, 2016

Yes.

@btmills
Copy link
Member

btmills commented Jan 18, 2016

✋ I am

@gyandeeps
Copy link
Member

Thats the reason. try node@4 it will fail on your machine also.
In node@5, it falls back to version of js-yaml which is being used by eslint as all the nested dependencies float to the top.

@alberto
Copy link
Member Author

alberto commented Jan 18, 2016

It's still green on my machine with [email protected] :/

@alberto
Copy link
Member Author

alberto commented Jan 18, 2016

Forget what I just said, I was on the wrong branch, where I had already tried to upgrade eslint and eslint-config-eslint. It fails with [email protected], as it should.

@alberto
Copy link
Member Author

alberto commented Jan 19, 2016

Thanks @gyandeeps for solving the mystery!

@nzakas nzakas closed this as completed in df5b71c Jan 19, 2016
nzakas added a commit that referenced this issue Jan 19, 2016
Upgrade: eslint and eslint-config-eslint (fixes #231)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants