Update: config extends dependency lookup (fixes #5023) #5070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -371,6 +350,11 @@ function resolve(filePath) { | |||
| filePath = "eslint-config-" + filePath; | |||
| } | |||
|
|
|||
| // some additional information processing is necessary | |||
| filePath = resolveModule.sync(filePath, { | |||
| basedir: relativeTo || process.cwd() | |||
There was a problem hiding this comment.
Do we want to use process.cwd here? This will affect cwd CLIEngine flag.
There was a problem hiding this comment.
Hmm yeah. Maybe I can get away without a default here. Let me double-check.
There was a problem hiding this comment.
Going to leave this for now. It will be an edge case for now, but I'll come back around and refactor later to do this correctly.
nzakas
added a commit
that referenced
this pull request
Jan 26, 2016
Update: config extends dependency lookup (fixes #5023)
|
After merging this PR, the build is broken. |
|
Found the reason, its broken because of the latest mocha release (3 hours ago). |
|
Weird. Thanks for finding this, I noticed just before I left. |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a bit trickier than I thought. I had to get rid of tests that were just too difficult to get working. However, the code coverage is basically the same, as the tests I removed were from
cliandconfig, both of which have way more tests than they should (as all they do is hand off data to other utilities....a lot of tests are left over from when all the logic was in these two files).