Chore: removes unnecessary assignment in loop #11780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
|
Thanks for the PR. Mind fixing the errors that are causing CI to fail so we can take a look? |
kaicataldo
added
chore
also reduces cyclomatic complexity with a slight reconfiguring of some conditions
|
@kaicataldo sorry 'bout that, made the change in github and it didn't show me the whitespace like I'm used to in my editor. should be fixed now. |
aladdin-add
reviewed
May 29, 2019
kaicataldo
approved these changes
Jun 8, 2019
ilyavolodin
approved these changes
Jun 8, 2019
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also reduces cyclomatic complexity with a slight reconfiguring of some conditions
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
see below
What changes did you make? (Give an overview)
I noticed that this code could be a tad bit improved by removing the assignment that was inside the for loop. I also reduced the complexity of the bottom bit slightly.
Is there anything you'd like reviewers to focus on?
it's a very small change. no.