Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Espree version for comment attachment fix #5923

Closed
kaicataldo opened this issue Apr 21, 2016 · 1 comment
Closed

Upgrade Espree version for comment attachment fix #5923

kaicataldo opened this issue Apr 21, 2016 · 1 comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features

Comments

@kaicataldo
Copy link
Member

Have a PR for this already. We should update the version of Espree that has this fix merged: eslint/js#264

Here's the PR: #5922
@eslintbot eslintbot added the triage An ESLint team member will look at this issue soon label Apr 21, 2016
@kaicataldo kaicataldo added bug ESLint is working incorrectly core Relates to ESLint's core APIs and features accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Apr 21, 2016
kaicataldo added a commit that referenced this issue Apr 21, 2016
@kaicataldo
Upgrade: espree 3.1.4 (fixes #5923)
e490f4e
@kaicataldo
Copy link
Member Author

cc @mysticatea This should also fix #5756!

@nzakas nzakas closed this as completed in 25d626a Apr 22, 2016
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kaicataldo @eslintbot