Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some executeOnText() tests are in the wrong describe block #2648

Closed
tikotzky opened this issue May 31, 2015 · 0 comments · Fixed by DavidKindler/meteor#3 · May be fixed by iamstoick/javascript#11
Closed

some executeOnText() tests are in the wrong describe block #2648

tikotzky opened this issue May 31, 2015 · 0 comments · Fixed by DavidKindler/meteor#3 · May be fixed by iamstoick/javascript#11
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion

Comments

@tikotzky
Copy link
Contributor

see:

it("should return a warning when given a filename by --stdin-filename in excluded files list", function() {
engine = new CLIEngine({
ignorePath: "tests/fixtures/.eslintignore"
});
var report = engine.executeOnText("var bar = foo;", "tests/fixtures/passing.js");
assert.equal(report.results.length, 1);
assert.equal(report.errorCount, 0);
assert.equal(report.warningCount, 1);
assert.equal(report.results[0].filePath, "tests/fixtures/passing.js");
assert.equal(report.results[0].messages[0].severity, 1);
assert.equal(report.results[0].messages[0].message, "File ignored because of your .eslintignore file. Use --no-ignore to override.");
assert.equal(report.results[0].errorCount, 0);
assert.equal(report.results[0].warningCount, 1);
});
it("should return a message when given a filename by --stdin-filename in excluded files list and ignore is off", function() {
engine = new CLIEngine({
ignorePath: "tests/fixtures/.eslintignore",
ignore: false,
reset: true,
rules: {
"no-undef": 2
}
});
var report = engine.executeOnText("var bar = foo;", "tests/fixtures/passing.js");
assert.equal(report.results.length, 1);
assert.equal(report.results[0].filePath, "tests/fixtures/passing.js");
assert.equal(report.results[0].messages[1].ruleId, "no-undef");
assert.equal(report.results[0].messages[1].severity, 2);
});

those lines are within describe("executeOnFiles()", ...
they should be move to be within ``describe("executeOnText()", ...`

ilyavolodin added a commit that referenced this issue May 31, 2015
Update: move executeOnText() tests to the correct describe block (fixes #2648)
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 7, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
1 participant