Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consistent-this incorrectly triggered when destructuring this #2633

Closed
davidaurelio opened this issue May 29, 2015 · 0 comments · Fixed by #2634 · May be fixed by iamstoick/javascript#11
Closed

consistent-this incorrectly triggered when destructuring this #2633

davidaurelio opened this issue May 29, 2015 · 0 comments · Fixed by #2634 · May be fixed by iamstoick/javascript#11
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules

Comments

@davidaurelio
Copy link 

const {a, b, c} = this;

Triggers consistent-this, but it should not.
@lo1tuma lo1tuma added bug ESLint is working incorrectly rule Relates to ESLint's core rules labels May 29, 2015
davidaurelio pushed a commit to davidaurelio/eslint that referenced this issue May 29, 2015
Fix: “consistent-this” incorrectly flagging destructuring of this (f…
32b0cde 
…ixes eslint#2633)
@davidaurelio davidaurelio mentioned this issue May 29, 2015
Merged
@ilyavolodin ilyavolodin added the accepted There is consensus among the team that this change meets the criteria for inclusion label May 29, 2015
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 7, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
3 participants
@davidaurelio @lo1tuma @ilyavolodin