update prefer-spread

eslint · Jun 18, 2020 · a3cbe6e · a3cbe6e
1 parent 651bac3
commit a3cbe6e
Show file tree

Hide file tree

Showing 2 changed files with 46 additions and 8 deletions.
diff --git a/lib/rules/prefer-spread.js b/lib/rules/prefer-spread.js
@@ -18,17 +18,13 @@ const astUtils = require("./utils/ast-utils");
  */
 function isVariadicApplyCalling(node) {
     return (
-        node.callee.type === "MemberExpression" &&
-        node.callee.property.type === "Identifier" &&
-        node.callee.property.name === "apply" &&
-        node.callee.computed === false &&
+        astUtils.isSpecificMemberAccess(node.callee, null, "apply") &&
         node.arguments.length === 2 &&
         node.arguments[1].type !== "ArrayExpression" &&
         node.arguments[1].type !== "SpreadElement"
     );
 }
 
-
 /**
  * Checks whether or not `thisArg` is not changed by `.apply()`.
  * @param {ASTNode|null} expectedThis The node that is the owner of the applied function.
@@ -75,7 +71,7 @@ module.exports = {
                     return;
                 }
 
-                const applied = node.callee.object;
+                const applied = astUtils.skipChainExpression(astUtils.skipChainExpression(node.callee).object);
                 const expectedThis = (applied.type === "MemberExpression") ? applied.object : null;
                 const thisArg = node.arguments[0];
 

diff --git a/tests/lib/rules/prefer-spread.js b/tests/lib/rules/prefer-spread.js
@@ -18,7 +18,7 @@ const { RuleTester } = require("../../../lib/rule-tester");
 
 const errors = [{ messageId: "preferSpread", type: "CallExpression" }];
 
-const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 6 } });
+const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 2020 } });
 
 ruleTester.run("prefer-spread", rule, {
     valid: [
@@ -39,7 +39,11 @@ ruleTester.run("prefer-spread", rule, {
         // ignores incomplete things.
         "foo.apply();",
         "obj.foo.apply();",
-        "obj.foo.apply(obj, ...args)"
+        "obj.foo.apply(obj, ...args)",
+
+        // Optional chaining
+        "(a?.b).c.foo.apply(a?.b.c, args);",
+        "a?.b.c.foo.apply((a?.b).c, args);"
     ],
     invalid: [
         {
@@ -73,6 +77,44 @@ ruleTester.run("prefer-spread", rule, {
         {
             code: "[].concat.apply([\n/*empty*/\n], args);",
             errors
+        },
+
+        // Optional chaining
+        {
+            code: "foo.apply?.(undefined, args);",
+            errors
+        },
+        {
+            code: "foo?.apply(undefined, args);",
+            errors
+        },
+        {
+            code: "foo?.apply?.(undefined, args);",
+            errors
+        },
+        {
+            code: "(foo?.apply)(undefined, args);",
+            errors
+        },
+        {
+            code: "(foo?.apply)?.(undefined, args);",
+            errors
+        },
+        {
+            code: "(obj?.foo).apply(obj, args);",
+            errors
+        },
+        {
+            code: "a?.b.c.foo.apply(a?.b.c, args);",
+            errors
+        },
+        {
+            code: "(a?.b.c).foo.apply(a?.b.c, args);",
+            errors
+        },
+        {
+            code: "(a?.b).c.foo.apply((a?.b).c, args);",
+            errors
         }
     ]
 });