Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add type tests #16

Merged
merged 2 commits into from
Nov 27, 2024
Merged

fix: add type tests #16

merged 2 commits into from
Nov 27, 2024

Conversation

fasttime
Copy link
Member

@fasttime fasttime commented Nov 26, 2024

Prerequisites checklist

What is the purpose of this pull request?

fix types and add type tests

What changes did you make? (Give an overview)

  • Refactoring to ensure that the generated plugin type includes all relevant properties, especially plugin.configs.recommended.
  • Added type tests similar to Change Request: add type tests json#61
  • Reformatted Markdown files using Prettier 3.4. Also updated the Prettier version in package.json.

Related Issues

eslint/json#52

Is there anything you'd like reviewers to focus on?

.md files were reformatted by Prettier. See https://prettier.io/blog/2024/11/26/3.4.0#markdown.

@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Nov 26, 2024
@fasttime fasttime marked this pull request as ready for review November 26, 2024 20:39
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit f21e090 into main Nov 27, 2024
16 checks passed
@nzakas nzakas deleted the test-types branch November 27, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants