Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: special handling of identifiers no longer required #825

Conversation

RebeccaStevens
Copy link
Collaborator

@RebeccaStevens RebeccaStevens commented May 3, 2024

No description provided.

Copy link

graphite-app bot commented May 3, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “Status: Merge Queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “Status: Hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

RebeccaStevens commented May 3, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @RebeccaStevens and the rest of your teammates on Graphite Graphite

@RebeccaStevens RebeccaStevens force-pushed the 05-03-fix_special_handling_of_identifiers_no_longer_required branch from 39029f2 to 417270c Compare May 6, 2024 01:00
@RebeccaStevens RebeccaStevens changed the base branch from 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs to 04-15-feat_eslint_9_migration May 6, 2024 01:00
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_eslint_9_migration branch from 2d9e9a8 to 0fa726e Compare May 6, 2024 01:17
@RebeccaStevens RebeccaStevens force-pushed the 05-03-fix_special_handling_of_identifiers_no_longer_required branch from 417270c to e582e36 Compare May 6, 2024 01:17
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_eslint_9_migration branch from 0fa726e to 61634b9 Compare May 6, 2024 04:12
@RebeccaStevens RebeccaStevens force-pushed the 05-03-fix_special_handling_of_identifiers_no_longer_required branch from e582e36 to d974bd2 Compare May 6, 2024 04:12
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_eslint_9_migration branch from 61634b9 to 61a88ee Compare May 6, 2024 04:30
@RebeccaStevens RebeccaStevens force-pushed the 05-03-fix_special_handling_of_identifiers_no_longer_required branch from d974bd2 to 8ecae19 Compare May 6, 2024 04:30
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_eslint_9_migration branch from 61a88ee to 4f6183b Compare May 6, 2024 10:23
@RebeccaStevens RebeccaStevens force-pushed the 05-03-fix_special_handling_of_identifiers_no_longer_required branch from 8ecae19 to 39e1740 Compare May 6, 2024 10:23
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_eslint_9_migration branch from 4f6183b to f824dc1 Compare May 6, 2024 11:30
@RebeccaStevens RebeccaStevens force-pushed the 05-03-fix_special_handling_of_identifiers_no_longer_required branch from 39e1740 to fd8c472 Compare May 6, 2024 11:30
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_eslint_9_migration branch from f824dc1 to 8eebe1f Compare May 6, 2024 12:16
@RebeccaStevens RebeccaStevens force-pushed the 05-03-fix_special_handling_of_identifiers_no_longer_required branch from fd8c472 to ec3670f Compare May 6, 2024 12:16
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_eslint_9_migration branch from 8eebe1f to b8809d4 Compare May 7, 2024 00:19
@RebeccaStevens RebeccaStevens force-pushed the 05-03-fix_special_handling_of_identifiers_no_longer_required branch from ec3670f to 4736e3c Compare May 7, 2024 00:19
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_eslint_9_migration branch from b8809d4 to e91c051 Compare May 9, 2024 23:55
@RebeccaStevens RebeccaStevens force-pushed the 05-03-fix_special_handling_of_identifiers_no_longer_required branch from 4736e3c to adbe742 Compare May 9, 2024 23:55
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_eslint_9_migration branch from e91c051 to 6c4fd54 Compare May 12, 2024 06:09
@RebeccaStevens RebeccaStevens force-pushed the 05-03-fix_special_handling_of_identifiers_no_longer_required branch from adbe742 to 4ba55b4 Compare May 12, 2024 06:09
@RebeccaStevens RebeccaStevens force-pushed the 05-03-fix_special_handling_of_identifiers_no_longer_required branch from bbe81a6 to b4bbb93 Compare May 25, 2024 11:16
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_eslint_9_migration branch from 3e308ad to ecf1f4a Compare May 25, 2024 12:39
@RebeccaStevens RebeccaStevens force-pushed the 05-03-fix_special_handling_of_identifiers_no_longer_required branch from b4bbb93 to edb0e74 Compare May 25, 2024 12:39
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_eslint_9_migration branch from ecf1f4a to ba79085 Compare May 25, 2024 13:32
@RebeccaStevens RebeccaStevens force-pushed the 05-03-fix_special_handling_of_identifiers_no_longer_required branch from edb0e74 to 880dacd Compare May 25, 2024 13:32
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_eslint_9_migration branch from ba79085 to bb4aeae Compare June 9, 2024 12:57
@RebeccaStevens RebeccaStevens force-pushed the 05-03-fix_special_handling_of_identifiers_no_longer_required branch from 880dacd to 1c6b118 Compare June 9, 2024 12:57
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_eslint_9_migration branch from bb4aeae to 51957bb Compare June 10, 2024 06:49
@RebeccaStevens RebeccaStevens force-pushed the 05-03-fix_special_handling_of_identifiers_no_longer_required branch from 1c6b118 to 830fe7c Compare June 10, 2024 06:49
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_eslint_9_migration branch from 51957bb to b27c8e8 Compare June 19, 2024 03:50
@RebeccaStevens RebeccaStevens force-pushed the 05-03-fix_special_handling_of_identifiers_no_longer_required branch from 830fe7c to 4f9fbe9 Compare June 19, 2024 03:50
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_eslint_9_migration branch from b27c8e8 to dfb21a4 Compare June 19, 2024 07:13
@RebeccaStevens RebeccaStevens force-pushed the 05-03-fix_special_handling_of_identifiers_no_longer_required branch from 4f9fbe9 to db8c3d8 Compare June 19, 2024 07:14
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_eslint_9_migration branch from dfb21a4 to 465ca72 Compare June 19, 2024 08:05
@RebeccaStevens RebeccaStevens force-pushed the 05-03-fix_special_handling_of_identifiers_no_longer_required branch from db8c3d8 to 48596a7 Compare June 19, 2024 08:05
BREAKING CHANGE: eslint 9 is now require
BREAKING CHANGE: typescript >= v4.7 is now required (when using typescript)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant