Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[functional/immutable-data] Doesn't take into consideration ignoreAccessorPattern with hash symbol #911

Closed
Clarchik opened this issue Dec 28, 2024 · 2 comments · Fixed by #921
Closed

[functional/immutable-data] Doesn't take into consideration ignoreAccessorPattern with hash symbol #911

Clarchik opened this issue Dec 28, 2024 · 2 comments · Fixed by #921
Labels
Breaking Change This change will require a new major release. Status: Released It's now live. Type: Bug Inconsistencies or issues which will cause a problem for users or implementors.

Comments

@Clarchik
Copy link

Bug Report

Seems like rule does not work as intended.

Expected behavior

Rule below should not produce error for variables which follows # symbol (TS private modifier)

'functional/immutable-data': [
      'error',
      {
        ignoreAccessorPattern: ['**._*', '**.#*']
      }
    ],

Actual behavior

Works for

this._anyName = value

But produces error for

this.#anyName = value

Modifying an existing object/array is not allowed.eslint[functional/immutable-data]

Steps to reproduce

Latest version (7.2.0) with the rule snippet above

Proposed changes
@Clarchik Clarchik added Status: Triage This issue needs to be triaged. Type: Bug Inconsistencies or issues which will cause a problem for users or implementors. labels Dec 28, 2024
@RebeccaStevens
Copy link
Collaborator

See #910 (comment)

@RebeccaStevens RebeccaStevens added Resolution: By Design The behavior reported in the issue is actually correct. and removed Type: Bug Inconsistencies or issues which will cause a problem for users or implementors. Status: Triage This issue needs to be triaged. labels Jan 5, 2025
@RebeccaStevens RebeccaStevens added Type: Bug Inconsistencies or issues which will cause a problem for users or implementors. Breaking Change This change will require a new major release. and removed Resolution: By Design The behavior reported in the issue is actually correct. labels Jan 14, 2025
@RebeccaStevens RebeccaStevens mentioned this issue Jan 14, 2025
Merged
RebeccaStevens added a commit that referenced this issue Jan 14, 2025
@RebeccaStevens
fix: prefix PrivateIdentifier names with a #
f5acf36 
BREAKING CHANGE: when using patterns to match against PrivateIdentifiers, their names are now
prefixed with a #.

fix #910 fix #911
@github-actions github-actions bot added the Status: Released It's now live. label Jan 14, 2025
RebeccaStevens added a commit that referenced this issue Jan 14, 2025
@RebeccaStevens
fix: prefix PrivateIdentifier names with a # (#921)
09b6474 
BREAKING CHANGE: when using patterns to match against PrivateIdentifiers, their names are now prefixed with a #.

fix #910 fix #911
github-actions bot pushed a commit that referenced this issue Jan 14, 2025
@semantic-release-bot
chore(release): 8.0.0 [skip ci]
793324a 
# [8.0.0](v7.3.0...v8.0.0) (2025-01-14)

### Bug Fixes

* prefix PrivateIdentifier names with a # ([#921](#921)) ([09b6474](09b6474)), closes [#910](#910) [#911](#911)

### BREAKING CHANGES

* when using patterns to match against PrivateIdentifiers, their names are now prefixed with a #.
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 8.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@eslint-functional eslint-functional deleted a comment from github-actions bot Jan 14, 2025
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this issue Jan 14, 2025
@renovate
fix(deps): update dependency eslint-plugin-functional to v8
0a9bacc 
##### [v8.0.0](https://github.com/eslint-functional/eslint-plugin-functional/blob/HEAD/CHANGELOG.md#800-2025-01-14)

##### Bug Fixes

-   prefix PrivateIdentifier names with a # ([#921](eslint-functional/eslint-plugin-functional#921)) ([09b6474](eslint-functional/eslint-plugin-functional@09b6474)), closes [#910](eslint-functional/eslint-plugin-functional#910) [#911](eslint-functional/eslint-plugin-functional#911)

##### BREAKING CHANGES

-   when using patterns to match against PrivateIdentifiers, their names are now prefixed with a #.
##### [v7.3.1](eslint-functional/eslint-plugin-functional@v7.3.0...v7.3.1)

##### [v7.3.0](https://github.com/eslint-functional/eslint-plugin-functional/blob/HEAD/CHANGELOG.md#730-2025-01-14)

##### Bug Fixes

-   **prefer-tacit:** improve suggestion message ([59194b2](eslint-functional/eslint-plugin-functional@59194b2))

##### Features

-   **type-declaration-immutability:** allow defining custom suggestion messages ([037a3c7](eslint-functional/eslint-plugin-functional@037a3c7))

#### [7.2.2](eslint-functional/eslint-plugin-functional@v7.2.1...v7.2.2) (2025-01-14)

#### [7.2.1](eslint-functional/eslint-plugin-functional@v7.2.0...v7.2.1) (2025-01-06)
##### [v7.2.2](https://github.com/eslint-functional/eslint-plugin-functional/blob/HEAD/CHANGELOG.md#722-2025-01-14)
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this issue Jan 15, 2025
@renovate
fix(deps): update dependency eslint-plugin-functional to v8
c94d770 
##### [v8.0.0](https://github.com/eslint-functional/eslint-plugin-functional/blob/HEAD/CHANGELOG.md#800-2025-01-14)

##### Bug Fixes

-   prefix PrivateIdentifier names with a # ([#921](eslint-functional/eslint-plugin-functional#921)) ([09b6474](eslint-functional/eslint-plugin-functional@09b6474)), closes [#910](eslint-functional/eslint-plugin-functional#910) [#911](eslint-functional/eslint-plugin-functional#911)

##### BREAKING CHANGES

-   when using patterns to match against PrivateIdentifiers, their names are now prefixed with a #.
##### [v7.3.1](eslint-functional/eslint-plugin-functional@v7.3.0...v7.3.1)

##### [v7.3.0](https://github.com/eslint-functional/eslint-plugin-functional/blob/HEAD/CHANGELOG.md#730-2025-01-14)

##### Bug Fixes

-   **prefer-tacit:** improve suggestion message ([59194b2](eslint-functional/eslint-plugin-functional@59194b2))

##### Features

-   **type-declaration-immutability:** allow defining custom suggestion messages ([037a3c7](eslint-functional/eslint-plugin-functional@037a3c7))

#### [7.2.2](eslint-functional/eslint-plugin-functional@v7.2.1...v7.2.2) (2025-01-14)

#### [7.2.1](eslint-functional/eslint-plugin-functional@v7.2.0...v7.2.1) (2025-01-06)
##### [v7.2.2](https://github.com/eslint-functional/eslint-plugin-functional/blob/HEAD/CHANGELOG.md#722-2025-01-14)
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this issue Jan 15, 2025
@renovate
fix(deps): update dependency eslint-plugin-functional to v8
6c19f27 
##### [v8.0.0](https://github.com/eslint-functional/eslint-plugin-functional/blob/HEAD/CHANGELOG.md#800-2025-01-14)

##### Bug Fixes

-   prefix PrivateIdentifier names with a # ([#921](eslint-functional/eslint-plugin-functional#921)) ([09b6474](eslint-functional/eslint-plugin-functional@09b6474)), closes [#910](eslint-functional/eslint-plugin-functional#910) [#911](eslint-functional/eslint-plugin-functional#911)

##### BREAKING CHANGES

-   when using patterns to match against PrivateIdentifiers, their names are now prefixed with a #.
##### [v7.3.1](eslint-functional/eslint-plugin-functional@v7.3.0...v7.3.1)

##### [v7.3.0](https://github.com/eslint-functional/eslint-plugin-functional/blob/HEAD/CHANGELOG.md#730-2025-01-14)

##### Bug Fixes

-   **prefer-tacit:** improve suggestion message ([59194b2](eslint-functional/eslint-plugin-functional@59194b2))

##### Features

-   **type-declaration-immutability:** allow defining custom suggestion messages ([037a3c7](eslint-functional/eslint-plugin-functional@037a3c7))

#### [7.2.2](eslint-functional/eslint-plugin-functional@v7.2.1...v7.2.2) (2025-01-14)

#### [7.2.1](eslint-functional/eslint-plugin-functional@v7.2.0...v7.2.1) (2025-01-06)
##### [v7.2.2](https://github.com/eslint-functional/eslint-plugin-functional/blob/HEAD/CHANGELOG.md#722-2025-01-14)
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this issue Jan 15, 2025
@renovate
fix(deps): update dependency eslint-plugin-functional to v8
ea55397 
##### [v8.0.0](https://github.com/eslint-functional/eslint-plugin-functional/blob/HEAD/CHANGELOG.md#800-2025-01-14)

##### Bug Fixes

-   prefix PrivateIdentifier names with a # ([#921](eslint-functional/eslint-plugin-functional#921)) ([09b6474](eslint-functional/eslint-plugin-functional@09b6474)), closes [#910](eslint-functional/eslint-plugin-functional#910) [#911](eslint-functional/eslint-plugin-functional#911)

##### BREAKING CHANGES

-   when using patterns to match against PrivateIdentifiers, their names are now prefixed with a #.
##### [v7.3.1](eslint-functional/eslint-plugin-functional@v7.3.0...v7.3.1)
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this issue Jan 15, 2025
@renovate
fix(deps): update dependency eslint-plugin-functional to v8
a103534 
##### [v8.0.0](https://github.com/eslint-functional/eslint-plugin-functional/blob/HEAD/CHANGELOG.md#800-2025-01-14)

##### Bug Fixes

-   prefix PrivateIdentifier names with a # ([#921](eslint-functional/eslint-plugin-functional#921)) ([09b6474](eslint-functional/eslint-plugin-functional@09b6474)), closes [#910](eslint-functional/eslint-plugin-functional#910) [#911](eslint-functional/eslint-plugin-functional#911)

##### BREAKING CHANGES

-   when using patterns to match against PrivateIdentifiers, their names are now prefixed with a #.
##### [v7.3.1](eslint-functional/eslint-plugin-functional@v7.3.0...v7.3.1)
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this issue Jan 15, 2025
@renovate
fix(deps): update dependency eslint-plugin-functional to v8
9f1b317 
##### [v8.0.0](https://github.com/eslint-functional/eslint-plugin-functional/blob/HEAD/CHANGELOG.md#800-2025-01-14)

##### Bug Fixes

-   prefix PrivateIdentifier names with a # ([#921](eslint-functional/eslint-plugin-functional#921)) ([09b6474](eslint-functional/eslint-plugin-functional@09b6474)), closes [#910](eslint-functional/eslint-plugin-functional#910) [#911](eslint-functional/eslint-plugin-functional#911)

##### BREAKING CHANGES

-   when using patterns to match against PrivateIdentifiers, their names are now prefixed with a #.
##### [v7.3.1](eslint-functional/eslint-plugin-functional@v7.3.0...v7.3.1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking Change This change will require a new major release. Status: Released It's now live. Type: Bug Inconsistencies or issues which will cause a problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: prefix PrivateIdentifier names with a # eslint-functional/eslint-plugin-functional
2 participants
@RebeccaStevens @Clarchik