Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promise/prefer-await-to-then ignore constructor scope #436

Closed
dimaMachina opened this issue Mar 31, 2023 · 2 comments · Fixed by #496
Closed

promise/prefer-await-to-then ignore constructor scope #436

dimaMachina opened this issue Mar 31, 2023 · 2 comments · Fixed by #496

Comments

@dimaMachina
Copy link

Description

promise/prefer-await-to-then should not report errors if .then/.catch calls are inside constructor of some class

Because we can't have async constructor

@yacinehmito
Copy link

You could always define an async function and call that function in the constructor without awaiting.

@brettz9
Copy link
Member

brettz9 commented Jul 20, 2024

While I think this could be done with configuration, I think some projects may prefer to avoid such usages in case there is something wrong with using Promises at all in a constructor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants