fix(no-missing-require): handle multiple resolvePaths (#383)

Co-authored-by: Sebastian Good <[email protected]>
eslint-community · Nov 15, 2024 · df6ad2a · df6ad2a
1 parent c4d1551
commit df6ad2a
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 1 deletion.
diff --git a/lib/util/import-target.js b/lib/util/import-target.js
@@ -270,6 +270,13 @@ module.exports = class ImportTarget {
         this.resolveError = error.message
     }
 
+    /**
+     * @returns {void}
+     */
+    resetResolutionError() {
+        this.resolveError = null
+    }
+
     /**
      * Resolve the given id to file paths.
      * @returns {string | null} The resolved path.
@@ -324,7 +331,10 @@ module.exports = class ImportTarget {
 
             try {
                 const resolved = requireResolve(baseDir, this.name)
-                if (typeof resolved === "string") return resolved
+                if (typeof resolved === "string") {
+                    this.resetResolutionError()
+                    return resolved
+                }
             } catch (error) {
                 this.handleResolutionError(error)
             }

diff --git a/tests/lib/rules/no-missing-import.js b/tests/lib/rules/no-missing-import.js
@@ -181,6 +181,11 @@ ruleTester.run("no-missing-import", rule, {
             code: "import a from './fixtures/no-missing/a.js';",
             options: [{ resolvePaths: ["tests"] }],
         },
+        {
+            filename: fixture("test.js"),
+            code: "import a from './fixtures/no-missing/a.js';",
+            options: [{ resolvePaths: ["scripts", "tests"] }],
+        },
 
         // typescriptExtensionMap
         {

diff --git a/tests/lib/rules/no-missing-require.js b/tests/lib/rules/no-missing-require.js
@@ -130,6 +130,16 @@ ruleTester.run("no-missing-require", rule, {
             code: "require('./fixtures/no-missing/a');",
             options: [{ resolvePaths: ["tests"] }],
         },
+        {
+            filename: fixture("test.js"),
+            code: "require('./fixtures/no-missing/a');",
+            options: [{ resolvePaths: ["scripts", "tests"] }],
+        },
+        {
+            filename: fixture("test.js"),
+            code: "require('./a');",
+            options: [{ resolvePaths: ["tests"] }],
+        },
 
         // Ignores it if not callee.
         {