Breaking: Update no-missing-placeholders, no-unused-placeholders, prefer-message-ids, prefer-placeholders rules to also apply to suggestion messages
#196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
force-pushed
the
no-missing-placeholders-suggestion
branch
2 times, most recently
from
6bf4356
to
25864c0
Compare
bmish
changed the title
no-missing-placeholders rule to also apply to suggestion messagesno-missing-placeholders and no-unused-placeholders rules to also apply to suggestion messages
bmish
force-pushed
the
no-missing-placeholders-suggestion
branch
from
25864c0
to
e072f20
Compare
bmish
force-pushed
the
no-missing-placeholders-suggestion
branch
2 times, most recently
from
e3ecac2
to
13b16e9
Compare
bmish
changed the title
no-missing-placeholders and no-unused-placeholders rules to also apply to suggestion messagesno-missing-placeholders, no-unused-placeholders, prefer-message-ids, prefer-placeholderds rules to also apply to suggestion messages
bmish
changed the title
no-missing-placeholders, no-unused-placeholders, prefer-message-ids, prefer-placeholderds rules to also apply to suggestion messagesno-missing-placeholders, no-unused-placeholders, prefer-message-ids, prefer-placeholders rules to also apply to suggestion messages
aladdin-add
reviewed
Sep 27, 2021
| const property = obj.properties.find(prop => prop.key.type === 'Identifier' && prop.key.name === keyName); | ||
| return property ? property.value : undefined; | ||
| } | ||
|
|
There was a problem hiding this comment.
same here, better to have a test for it. :)
There was a problem hiding this comment.
Agreed, added a test for the new util function collectReportViolationAndSuggestionData.
… `prefer-message-ids`, `prefer-placeholders` rules to also apply to suggestion messages
bmish
force-pushed
the
no-missing-placeholders-suggestion
branch
from
13b16e9
to
123d8fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rules should apply to both violation messages and suggestion messages.
Fixes #191.
Part of v4 release (#120).