[Close #11] Euen.11.rebar3 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Euen
force-pushed
the
euen.11.rebar3
branch
2 times, most recently
from
4461692 to
0a700ca
Compare
elbrujohalcon
suggested changes
Apr 24, 2017
src/fusco.erl
Outdated
| if | ||
| ClientConnection -> | ||
| fusco_sock:close(Socket, State#client_state.ssl), | ||
| case ClientConnection of |
There was a problem hiding this comment.
Why not just…
case fusco_lib:is_close(ConHdr) of?
src/fusco.erl
Outdated
| %%------------------------------------------------------------------------------ | ||
| %% @private | ||
| %%------------------------------------------------------------------------------ | ||
| inet_getaddr({ok, _}) -> true; |
There was a problem hiding this comment.
This function should be called is_proper_addr or is_ok_response or something clearer
Euen
force-pushed
the
euen.11.rebar3
branch
2 times, most recently
from
775bcc1 to
fda6252
Compare
rebar.config
Outdated
| ]}, | ||
| {shell, [ | ||
| {deps, [ | ||
| {sync, {git, "https://github.com/rustyio/sync.git", {ref, "9c78e7b"}}} |
There was a problem hiding this comment.
remove this dependency if possible, (maybe leave it in as a recommended and commented entry?)
Euen
force-pushed
the
euen.11.rebar3
branch
7 times, most recently
from
39418ce to
bfa008b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.