Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package signing script to the CI pipeline #4399

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jacekwegr
Copy link
Contributor

@jacekwegr jacekwegr commented Nov 15, 2024

Summary

This PR adds package signing to the CI pipeline. Packages are signed after they are built, and a check is added to make sure the signed packages can be verified. It also updates the package-building command to use a compression format that works with the signing tool.

Key Changes

  1. Package Signing

    • Adds a step to sign packages using GPG.
    • Includes a check to make sure the signature works and can be verified.
    • The script uses different signing tools depending on the type of the package.
  2. Compression Format

    • Switched the building process to explicitly use the xz compression format since the default was changed to zstd in newer Ubuntu/Debian versions, which is not supported by dpkg-sig tool.
  3. Environment Variables

    • Adds GPG_PUBLIC_KEY, GPG_PRIVATE_KEY and GPG_PASS as environment variables in CircleCI.
    • Both public and private keys are encoded in base64 so they can be stored as single lines, solving problems with multi-line keys.

@mongoose-im

This comment was marked as outdated.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.26%. Comparing base (d4bc662) to head (06a1b70).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4399      +/-   ##
==========================================
+ Coverage   85.05%   85.26%   +0.20%     
==========================================
  Files         550      550              
  Lines       33861    33861              
==========================================
+ Hits        28802    28872      +70     
+ Misses       5059     4989      -70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@jacekwegr jacekwegr force-pushed the sign-mim-packages branch 4 times, most recently from 47fccd1 to cf287d7 Compare November 20, 2024 09:26
@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@jacekwegr jacekwegr marked this pull request as ready for review November 20, 2024 14:01
@jacekwegr jacekwegr changed the title Add script to sign packages [WiP] Add script to sign packages Nov 21, 2024
@jacekwegr jacekwegr marked this pull request as draft November 21, 2024 09:40
@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Nov 21, 2024

elasticsearch_and_cassandra_27 / elasticsearch_and_cassandra_mnesia / 06a1b70
Reports root/ big
OK: 473 / Failed: 0 / User-skipped: 49 / Auto-skipped: 0


small_tests_27_arm64 / small_tests / 06a1b70
Reports root / small


small_tests_26 / small_tests / 06a1b70
Reports root / small


small_tests_27 / small_tests / 06a1b70
Reports root / small


ldap_mnesia_26 / ldap_mnesia / 06a1b70
Reports root/ big
OK: 2350 / Failed: 0 / User-skipped: 910 / Auto-skipped: 0


ldap_mnesia_27 / ldap_mnesia / 06a1b70
Reports root/ big
OK: 2350 / Failed: 0 / User-skipped: 910 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 06a1b70
Reports root/ big
OK: 4755 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0


dynamic_domains_mysql_redis_27 / mysql_redis / 06a1b70
Reports root/ big
OK: 4722 / Failed: 0 / User-skipped: 152 / Auto-skipped: 0


internal_mnesia_27 / internal_mnesia / 06a1b70
Reports root/ big
OK: 2492 / Failed: 0 / User-skipped: 768 / Auto-skipped: 0


pgsql_cets_27 / pgsql_cets / 06a1b70
Reports root/ big
OK: 4632 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_27 / odbc_mssql_mnesia / 06a1b70
Reports root/ big
OK: 4752 / Failed: 0 / User-skipped: 122 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_27 / pgsql_mnesia / 06a1b70
Reports root/ big
OK: 4755 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0


pgsql_mnesia_27 / pgsql_mnesia / 06a1b70
Reports root/ big
OK: 5146 / Failed: 0 / User-skipped: 128 / Auto-skipped: 0


mysql_redis_27 / mysql_redis / 06a1b70
Reports root/ big
OK: 5127 / Failed: 0 / User-skipped: 147 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / 06a1b70
Reports root/ big
OK: 5146 / Failed: 0 / User-skipped: 128 / Auto-skipped: 0


cockroachdb_cets_27 / cockroachdb_cets / 06a1b70
Reports root/ big
OK: 4632 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0


mssql_mnesia_27 / odbc_mssql_mnesia / 06a1b70
Reports root/ big
OK: 5143 / Failed: 0 / User-skipped: 131 / Auto-skipped: 0

@jacekwegr jacekwegr changed the title [WiP] Add script to sign packages Add package signing script to the CI pipeline Nov 22, 2024
@jacekwegr jacekwegr marked this pull request as ready for review November 22, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants