Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve serializable dict #569

Merged
merged 6 commits into from
Sep 20, 2023
Merged

Improve serializable dict #569

merged 6 commits into from
Sep 20, 2023

Conversation

tensionhead
Copy link
Contributor

@tensionhead tensionhead commented Sep 15, 2023

Changes Summary

  • pass through error messages of json.dumps
  • try the _serialize_value helper before testing serializability
  • added test

Reviewer Checklist

  • Are testing routines present?
  • Do objects in the global package namespace perform proper parsing of their input?
  • Are all docstrings complete and accurate?
  • Is the CHANGELOG.md up to date?

- now tries to convert simple sequences on the fly

Changes to be committed:
	modified:   syncopy/shared/tools.py
Changes to be committed:
	modified:   syncopy/tests/test_tools.py
- needed SPYError for better readability of msg

Changes to be committed:
	modified:   syncopy/tests/test_info.py
	modified:   syncopy/tests/test_selectdata.py
Changes to be committed:
	modified:   syncopy/tests/test_info.py
Changes to be committed:
	modified:   syncopy/tests/test_info.py
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.14% ⚠️

Comparison is base (9b1d86b) 69.10% compared to head (200b541) 68.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #569      +/-   ##
==========================================
- Coverage   69.10%   68.97%   -0.14%     
==========================================
  Files          87       87              
  Lines       10213    10217       +4     
  Branches     2151     2153       +2     
==========================================
- Hits         7058     7047      -11     
- Misses       2559     2574      +15     
  Partials      596      596              
Files Changed Coverage Δ
syncopy/shared/tools.py 86.71% <100.00%> (+0.42%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tensionhead tensionhead merged commit 3a6e5f3 into dev Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant