Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair n taper defaults #559

Merged
merged 7 commits into from
Jul 26, 2023
Merged

Repair n taper defaults #559

merged 7 commits into from
Jul 26, 2023

Conversation

tensionhead
Copy link
Contributor

@tensionhead tensionhead commented Jul 26, 2023

Changes Summary

  • comparison with FT unmasked errors in the default Slepian/multi-taper settings
  • minimal bandwidth was a factor of 2 too big
  • dpss settings were wrongly calculated from padded signal lengths

Reviewer Checklist

  • Are testing routines present?
  • Do objects in the global package namespace perform proper parsing of their input?
  • Are all docstrings complete and accurate?
  • Is the CHANGELOG.md up to date?

- there was a factor 2 too much

Changes to be committed:
	modified:   syncopy/shared/input_processors.py
- for long paddings the slepian parameter where quite off :/

Changes to be committed:
	modified:   syncopy/specest/freqanalysis.py
- can't take the padded signal lengths here either..
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.15% 🎉

Comparison is base (d8d7a8b) 68.88% compared to head (59aa767) 69.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #559      +/-   ##
==========================================
+ Coverage   68.88%   69.03%   +0.15%     
==========================================
  Files          87       87              
  Lines       10118    10122       +4     
  Branches     2124     2125       +1     
==========================================
+ Hits         6970     6988      +18     
+ Misses       2564     2550      -14     
  Partials      584      584              
Files Changed Coverage Δ
syncopy/specest/freqanalysis.py 66.06% <ø> (+3.63%) ⬆️
syncopy/connectivity/connectivity_analysis.py 84.31% <100.00%> (+0.31%) ⬆️
syncopy/shared/input_processors.py 57.50% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tensionhead tensionhead merged commit 7dc28b4 into dev Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant