CHG: Normalize spectra independent of padding #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this implements Pascal's original power normalization intention - added `ft_compat` parameter for mtmfft to get FT behavior if needed Changes to be committed: modified: syncopy/specest/freqanalysis.py modified: syncopy/specest/mtmconvol.py modified: syncopy/specest/mtmfft.py modified: syncopy/tests/test_specest.py
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #459 +/- ##
==========================================
+ Coverage 68.77% 68.95% +0.18%
==========================================
Files 84 84
Lines 10125 10129 +4
Branches 2081 2083 +2
==========================================
+ Hits 6963 6984 +21
+ Misses 2628 2623 -5
+ Partials 534 522 -12
... and 7 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
dfsp-spirit
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Summary
ft_compatparameter forfreqanalysis --> mtmfftto get FT behavior if neededmtmconvolas here the individual segments get not padded (modulo the edges)Reviewer Checklist