Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add redefinetrial #449

Merged
merged 9 commits into from
Mar 22, 2023
Merged

Add redefinetrial #449

merged 9 commits into from
Mar 22, 2023

Conversation

tensionhead
Copy link
Contributor

@tensionhead tensionhead commented Mar 17, 2023 •
edited by dfsp-spirit
Loading

Changes Summary

Reviewer Checklist

  • Are testing routines present?
  • Do objects in the global package namespace perform proper parsing of their input?
  • Are all docstrings complete and accurate?
  • Is the CHANGELOG.md up to date?

@tensionhead
WIP: add redefinetrial
eb3908b
@tensionhead
NEW: redefinetrial
86dfbed 
- did not implement this stitching so far..
- TODO: tests

Changes to be committed:
	modified:   syncopy/datatype/methods/redefinetrial.py
	modified:   syncopy/shared/tools.py
@tensionhead
NEW: redefinetrial tests
780657e 
Changes to be committed:
	modified:   syncopy/datatype/__init__.py
	modified:   syncopy/datatype/methods/redefinetrial.py
	new file:   syncopy/tests/test_redefinetrial.py
@tensionhead tensionhead added Feature Request A concrete request (as detailed as possible) to either add or change functionality. FT compat Field Trip compatibility labels Mar 17, 2023
@tensionhead tensionhead changed the base branch from master to dev March 17, 2023 14:11
@codecov
Copy link

codecov bot commented Mar 17, 2023 •
edited
Loading

Codecov Report

Patch coverage: 96.19% and project coverage change: -0.15 ⚠️

Comparison is base (bf5392a) 68.79% compared to head (ba971ac) 68.65%.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #449      +/-   ##
==========================================
- Coverage   68.79%   68.65%   -0.15%     
==========================================
  Files          83       84       +1     
  Lines       10019    10122     +103     
  Branches     2056     2081      +25     
==========================================
+ Hits         6893     6949      +56     
- Misses       2604     2639      +35     
- Partials      522      534      +12
Impacted Files Coverage Δ
syncopy/datatype/methods/redefinetrial.py 96.03% <96.03%> (ø)
syncopy/datatype/__init__.py 100.00% <100.00%> (ø)
syncopy/shared/tools.py 86.29% <100.00%> (ø)

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tensionhead tensionhead marked this pull request as ready for review March 17, 2023 14:31
@dfsp-spirit dfsp-spirit self-assigned this Mar 22, 2023
dfsp-spirit
dfsp-spirit approved these changes Mar 22, 2023
View reviewed changes
Copy link
Collaborator

@dfsp-spirit dfsp-spirit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have added some minor fixes myself. This is now approved.

syncopy/datatype/methods/redefinetrial.py Show resolved Hide resolved
syncopy/datatype/methods/redefinetrial.py Outdated Show resolved Hide resolved
syncopy/datatype/methods/redefinetrial.py Outdated Show resolved Hide resolved
@dfsp-spirit dfsp-spirit merged commit 414d763 into dev Mar 22, 2023
@tensionhead
Copy link
Contributor Author

Great, thx!

@tensionhead tensionhead deleted the add_redefinetrial branch March 31, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfsp-spirit dfsp-spirit dfsp-spirit approved these changes

Assignees

@dfsp-spirit dfsp-spirit

Labels
Feature Request A concrete request (as detailed as possible) to either add or change functionality. FT compat Field Trip compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tensionhead @dfsp-spirit