Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New _register_dataset tests #436

Merged
merged 1 commit into from
Feb 10, 2023
Merged

New _register_dataset tests #436

merged 1 commit into from
Feb 10, 2023

Conversation

dfsp-spirit
Copy link
Collaborator

Changes Summary

  • Add tests that use _register_dataset() on SpikeData and EventData instances.

Reviewer Checklist

  • Are testing routines present?
  • Do objects in the global package namespace perform proper parsing of their input?
  • Are all docstrings complete and accurate?
  • Is the CHANGELOG.md up to date?

@dfsp-spirit dfsp-spirit changed the base branch from master to dev February 9, 2023 12:36
@dfsp-spirit dfsp-spirit changed the title New registerdataset test New _register_dataset tests Feb 9, 2023
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 67.79% // Head: 68.13% // Increases project coverage by +0.34% 🎉

Coverage data is based on head (116f657) compared to base (5df8e15).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #436      +/-   ##
==========================================
+ Coverage   67.79%   68.13%   +0.34%     
==========================================
  Files          81       81              
  Lines        9833     9833              
  Branches     2032     2032              
==========================================
+ Hits         6666     6700      +34     
+ Misses       2622     2595      -27     
+ Partials      545      538       -7     
Impacted Files Coverage Δ
syncopy/datatype/methods/show.py 58.33% <0.00%> (-3.34%) ⬇️
syncopy/specest/compRoutines.py 91.91% <0.00%> (+2.35%) ⬆️
syncopy/specest/mtmconvol.py 93.54% <0.00%> (+6.45%) ⬆️
syncopy/specest/stft.py 83.33% <0.00%> (+7.14%) ⬆️
syncopy/specest/freqanalysis.py 69.09% <0.00%> (+7.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@tensionhead tensionhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 🙂

@dfsp-spirit dfsp-spirit marked this pull request as ready for review February 10, 2023 13:13
@tensionhead tensionhead merged commit 7546f51 into dev Feb 10, 2023
@dfsp-spirit dfsp-spirit deleted the new_registerdataset_test branch February 22, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants