Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log function to syncopy root namespace #430

Merged
merged 4 commits into from
Jan 30, 2023
Merged

Add log function to syncopy root namespace #430

merged 4 commits into from
Jan 30, 2023

Conversation

dfsp-spirit
Copy link
Collaborator

@dfsp-spirit dfsp-spirit commented Jan 30, 2023

Changes Summary

  • Adds a syncopy.log() function that can be used to log without first importing stuff from submodules, and supports both the sequential and the parallel loggers:
import syncopy as spy
spy.log("We are about to get real.", level="IMPORTANT")
spy.log("oh no, an error in parallel code!", level="ERROR", par=True)

Reviewer Checklist

  • Are testing routines present?
  • Do objects in the global package namespace perform proper parsing of their input?
  • Are all docstrings complete and accurate?
  • Is the CHANGELOG.md up to date?

@dfsp-spirit dfsp-spirit changed the base branch from master to dev January 30, 2023 12:35
@dfsp-spirit dfsp-spirit marked this pull request as ready for review January 30, 2023 12:36
@dfsp-spirit dfsp-spirit changed the title Global log Add log function to syncopy root namespace Jan 30, 2023
Copy link
Contributor

@tensionhead tensionhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, with this spy.log() can be conveniently used to drop persistent messages!

@tensionhead tensionhead merged commit c4c89c9 into dev Jan 30, 2023
@dfsp-spirit dfsp-spirit deleted the global_log branch February 28, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants