Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW: TrialIndexer #422

Merged
merged 3 commits into from
Jan 16, 2023
Merged

NEW: TrialIndexer #422

merged 3 commits into from
Jan 16, 2023

Conversation

tensionhead
Copy link
Contributor

@tensionhead tensionhead commented Jan 16, 2023

Changes Summary

  • replaces the somewhat over-engineered yet still inefficient Indexer, backing the .trials property
  • the new TrialIndexer can also be used both as an iterable or via explicit (single element) indexing

Reviewer Checklist

  • Are testing routines present?
  • Do objects in the global package namespace perform proper parsing of their input?
  • Are all docstrings complete and accurate?
  • Is the CHANGELOG.md up to date?

- can be used both as an iterable or via explicit (single element) indexing

Changes to be committed:
	modified:   syncopy/__init__.py
	modified:   syncopy/datatype/__init__.py
	modified:   syncopy/datatype/base_data.py
	modified:   syncopy/datatype/discrete_data.py
	new file:   syncopy/datatype/util.py
	modified:   syncopy/statistics/spike_psth.py
	modified:   syncopy/statistics/summary_stats.py
	modified:   syncopy/tests/test_selectdata.py
@tensionhead tensionhead linked an issue Jan 16, 2023 that may be closed by this pull request
Changes to be committed:
	modified:   syncopy/datatype/util.py
	modified:   syncopy/tests/test_basedata.py
Changes to be committed:
	modified:   syncopy/tests/test_basedata.py
@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Base: 68.52% // Head: 68.58% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (e3dbb3e) compared to base (9a61c46).
Patch coverage: 70.73% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #422      +/-   ##
==========================================
+ Coverage   68.52%   68.58%   +0.05%     
==========================================
  Files          79       80       +1     
  Lines        9610     9599      -11     
  Branches     1995     1992       -3     
==========================================
- Hits         6585     6583       -2     
+ Misses       2513     2501      -12     
- Partials      512      515       +3     
Impacted Files Coverage Δ
syncopy/statistics/spike_psth.py 95.34% <ø> (-0.06%) ⬇️
syncopy/datatype/base_data.py 79.64% <60.00%> (+1.72%) ⬆️
syncopy/datatype/util.py 70.14% <70.14%> (ø)
syncopy/datatype/__init__.py 100.00% <100.00%> (ø)
syncopy/datatype/discrete_data.py 78.57% <100.00%> (+0.26%) ⬆️
syncopy/statistics/summary_stats.py 74.53% <100.00%> (+0.15%) ⬆️
syncopy/plotting/_helpers.py 85.91% <0.00%> (-5.64%) ⬇️
syncopy/datatype/methods/show.py 73.33% <0.00%> (-1.67%) ⬇️
syncopy/plotting/mp_plotting.py 44.66% <0.00%> (-1.34%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@KatharineShapcott KatharineShapcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it all looks good!

@tensionhead tensionhead merged commit b95e7cd into dev Jan 16, 2023
@tensionhead tensionhead deleted the 418-re-implement-trials branch January 16, 2023 17:18
@tensionhead tensionhead mentioned this pull request Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-implement .trials
2 participants