Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Serialize cfg entries #407

Merged
merged 5 commits into from
Jan 5, 2023
Merged

FIX: Serialize cfg entries #407

merged 5 commits into from
Jan 5, 2023

Conversation

tensionhead
Copy link
Contributor

  • such that the cfg's can be stored in the jsons

Author Guidelines

  • Is the change set < 600 lines?
  • Was the code checked for memory leaks/performance bottlenecks?
  • Is the code running locally and on the ESI cluster?
  • Is the code running on all supported platforms?

Reviewer Checklist

  • Are testing routines present?
  • Do parallel loops have a set length and correct termination conditions?
  • Do objects in the global package namespace perform proper parsing of their input?
  • Do code-blocks provide novel functionality, i.e., no re-factoring using builtin/external packages possible?
  • Code layout
    • Is the code PEP8 compliant?
    • Does the code adhere to agreed-upon naming conventions?
    • Are keywords clearly named and easy to understand?
    • No commented-out code?
  • Are all docstrings complete and accurate?
  • Is the CHANGELOG.md up to date?

@tensionhead
FIX: Serialize cfg entries
ee299c9 
- such that the cfg's can be stored in the jsons

Changes to be committed:
	modified:   syncopy/shared/tools.py
@tensionhead
FIX: select dict and range objects
2db16b4 
- also adjust cfg tests

Changes to be committed:
	modified:   syncopy/shared/tools.py
	modified:   syncopy/tests/test_cfg.py
@tensionhead
FIX: list casting for ranges
b79e179 
Changes to be committed:
	modified:   syncopy/shared/tools.py
@tensionhead
FIX: pop select from kwargs
19f295d 
Changes to be committed:
	modified:   syncopy/shared/tools.py
@tensionhead
CHG: Remove slice as valid selection parameter type
2563103 
- it's not serializable and of doubtful practical use

Changes to be committed:
	modified:   syncopy/tests/test_continuousdata.py
	modified:   syncopy/tests/test_selectdata.py
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Base: 68.77% // Head: 68.53% // Decreases project coverage by -0.24% ⚠️

Coverage data is based on head (2563103) compared to base (13ed76e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #407      +/-   ##
==========================================
- Coverage   68.77%   68.53%   -0.25%     
==========================================
  Files          79       79              
  Lines        9585     9610      +25     
  Branches     1984     1995      +11     
==========================================
- Hits         6592     6586       -6     
- Misses       2495     2513      +18     
- Partials      498      511      +13
Impacted Files Coverage Δ
syncopy/shared/tools.py 86.29% <100.00%> (+3.46%) ⬆️
syncopy/specest/stft.py 72.97% <0.00%> (-8.11%) ⬇️
syncopy/specest/mtmconvol.py 85.18% <0.00%> (-7.41%) ⬇️
syncopy/specest/freqanalysis.py 65.34% <0.00%> (-3.65%) ⬇️
syncopy/datatype/base_data.py 77.92% <0.00%> (-1.19%) ⬇️
syncopy/specest/compRoutines.py 90.78% <0.00%> (-1.03%) ⬇️
syncopy/datatype/continuous_data.py 80.62% <0.00%> (-0.52%) ⬇️
syncopy/datatype/methods/arithmetic.py 71.09% <0.00%> (+2.31%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tensionhead tensionhead marked this pull request as ready for review January 3, 2023 18:58
@dfsp-spirit dfsp-spirit merged commit 7ecd1e8 into dev Jan 5, 2023
@tensionhead
Copy link
Contributor Author

Thx for the last fixes!

This was referenced Jan 5, 2023
Merged
Closed
Closed
@tensionhead tensionhead deleted the 392-serializable-cfg-entries branch March 31, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfsp-spirit dfsp-spirit dfsp-spirit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tensionhead @dfsp-spirit