-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
394 fix structdict copy #400
Conversation
Codecov ReportBase: 68.66% // Head: 68.48% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev #400 +/- ##
==========================================
- Coverage 68.66% 68.48% -0.19%
==========================================
Files 79 79
Lines 9567 9588 +21
Branches 1952 1954 +2
==========================================
- Hits 6569 6566 -3
- Misses 2499 2514 +15
- Partials 499 508 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, this will make the StructDict
behavior more consistent.. just one question, how can we make deep copies? The default shallow copies seem quite dangerous from a user perspective?!
I have implemented a I have also implemented import copy
my_cfg_cp = copy.deepcopy(my_cfg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok great, now ppl can safely throw around .copy()
on their cfg
's 👍
- only relevant if selection get reapplied from Selector.select dict Changes to be committed: modified: syncopy/plotting/_helpers.py modified: syncopy/shared/latency.py modified: syncopy/statistics/spike_psth.py modified: syncopy/statistics/timelockanalysis.py
Author Guidelines
Reviewer Checklist