Dev merge for 2022.12 release #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to be committed: modified: syncopy/tests/synth_data.py
Changes to be committed: modified: syncopy/tests/test_metadata.py
- introduced also maximal smoothing bandwidth - added all supported output keys to spectralDTypes Changes to be committed: modified: syncopy/plotting/_helpers.py modified: syncopy/plotting/sp_plotting.py modified: syncopy/shared/const_def.py modified: syncopy/shared/input_processors.py modified: syncopy/specest/freqanalysis.py modified: syncopy/specest/mtmfft.py
Changes to be committed: modified: syncopy/plotting/_helpers.py modified: syncopy/plotting/mp_plotting.py modified: syncopy/shared/input_processors.py modified: syncopy/tests/helpers.py modified: syncopy/tests/test_plotting.py
- now return also the fig, ax for CrossSpectralData plotting, addresses #357 Changes to be committed: modified: syncopy/plotting/mp_plotting.py modified: syncopy/plotting/sp_plotting.py modified: syncopy/specest/freqanalysis.py modified: syncopy/tests/test_plotting.py
- this now allows plotting individual tapers by setting output='imag' or 'real' - also imaginary/real part of coherence is now plottable Changes to be committed: modified: syncopy/nwanalysis/AV_compRoutines.py modified: syncopy/nwanalysis/connectivity_analysis.py modified: syncopy/plotting/_helpers.py modified: syncopy/plotting/mp_plotting.py modified: syncopy/plotting/sp_plotting.py
- also cut back on the random selections Changes to be committed: modified: syncopy/plotting/mp_plotting.py modified: syncopy/tests/test_plotting.py
Changes to be committed: modified: syncopy/shared/input_processors.py modified: syncopy/tests/test_plotting.py modified: syncopy/tests/test_specest.py
- now all what remains is to populate the SpectralData input branch Changes to be committed: modified: syncopy/nwanalysis/connectivity_analysis.py
- basic manual testing shows sames results when compared to AnalogData input after freqanalysis Changes to be committed: modified: syncopy/nwanalysis/ST_compRoutines.py modified: syncopy/nwanalysis/connectivity_analysis.py modified: syncopy/nwanalysis/csd.py modified: syncopy/shared/computational_routine.py modified: syncopy/shared/input_processors.py
- also smaller fixes regarding effective parameter checks Changes to be committed: modified: syncopy/nwanalysis/ST_compRoutines.py modified: syncopy/nwanalysis/connectivity_analysis.py modified: syncopy/shared/const_def.py modified: syncopy/shared/input_processors.py modified: syncopy/specest/compRoutines.py modified: syncopy/specest/freqanalysis.py
- to reach agreement with Granger connectivity analysis, there this is on by default - added also basic test of polymorphic connectivity frontend Changes to be committed: modified: syncopy/nwanalysis/connectivity_analysis.py modified: syncopy/specest/freqanalysis.py modified: syncopy/tests/test_connectivity.py
- check conditions on SpectralData (complex, multi-trial, no taper average) - fidelity of both ways to get to a result is checked Changes to be committed: modified: syncopy/nwanalysis/connectivity_analysis.py modified: syncopy/shared/input_processors.py modified: syncopy/tests/test_connectivity.py
- instead of digging into cfgs, just check that the dtype of the SpectralData is complex. This should allow more free pre-processing Changes to be committed: modified: syncopy/nwanalysis/connectivity_analysis.py modified: syncopy/tests/test_connectivity.py
…upport-custom-dimords 349 plotting does not support custom dimords
- all other load functions have no leading `_` Changes to be committed: modified: syncopy/io/__init__.py renamed: syncopy/io/_load_nwb.py -> syncopy/load_nwb.py
- works only on the ESI cluster and with pynwb installed in the env Changes to be committed: modified: syncopy/io/__init__.py deleted: syncopy/load_nwb.py modified: syncopy/tests/test_spyio.py
Changes to be committed: modified: syncopy/io/__init__.py new file: syncopy/io/load_nwb.py
memory-improvements-nwb
…ce-itc 367 inter trial coherence itc
Changes to be committed: modified: syncopy/datatype/continuous_data.py modified: syncopy/plotting/sp_plotting.py modified: syncopy/specest/freqanalysis.py modified: syncopy/tests/test_welch.py
368 welchs method
Codecov ReportBase: 65.83% // Head: 68.72% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #390 +/- ##
==========================================
+ Coverage 65.83% 68.72% +2.89%
==========================================
Files 77 79 +2
Lines 8730 9534 +804
Branches 1785 1947 +162
==========================================
+ Hits 5747 6552 +805
+ Misses 2594 2481 -113
- Partials 389 501 +112
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Changes to be committed: modified: poetry.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's fix the conflicts