364 rewire connectivity analysis #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- now all what remains is to populate the SpectralData input branch Changes to be committed: modified: syncopy/nwanalysis/connectivity_analysis.py
- basic manual testing shows sames results when compared to AnalogData input after freqanalysis Changes to be committed: modified: syncopy/nwanalysis/ST_compRoutines.py modified: syncopy/nwanalysis/connectivity_analysis.py modified: syncopy/nwanalysis/csd.py modified: syncopy/shared/computational_routine.py modified: syncopy/shared/input_processors.py
- also smaller fixes regarding effective parameter checks Changes to be committed: modified: syncopy/nwanalysis/ST_compRoutines.py modified: syncopy/nwanalysis/connectivity_analysis.py modified: syncopy/shared/const_def.py modified: syncopy/shared/input_processors.py modified: syncopy/specest/compRoutines.py modified: syncopy/specest/freqanalysis.py
- to reach agreement with Granger connectivity analysis, there this is on by default - added also basic test of polymorphic connectivity frontend Changes to be committed: modified: syncopy/nwanalysis/connectivity_analysis.py modified: syncopy/specest/freqanalysis.py modified: syncopy/tests/test_connectivity.py
- check conditions on SpectralData (complex, multi-trial, no taper average) - fidelity of both ways to get to a result is checked Changes to be committed: modified: syncopy/nwanalysis/connectivity_analysis.py modified: syncopy/shared/input_processors.py modified: syncopy/tests/test_connectivity.py
- instead of digging into cfgs, just check that the dtype of the SpectralData is complex. This should allow more free pre-processing Changes to be committed: modified: syncopy/nwanalysis/connectivity_analysis.py modified: syncopy/tests/test_connectivity.py
Codecov ReportBase: 69.84% // Head: 70.25% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev #366 +/- ##
==========================================
+ Coverage 69.84% 70.25% +0.41%
==========================================
Files 76 76
Lines 9009 9065 +56
Branches 1890 1902 +12
==========================================
+ Hits 6292 6369 +77
+ Misses 2273 2256 -17
+ Partials 444 440 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dfsp-spirit
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #364 , such that users can fine-tune and post-process
SpectralDatabefore inputting intoconnectivityanalysis. The old way of directly inputtingAnalogDatawas preserved.Author Guidelines
Reviewer Checklist