Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seq stats premerge #350

Merged
merged 64 commits into from
Sep 14, 2022
Merged

Seq stats premerge #350

merged 64 commits into from
Sep 14, 2022

Conversation

dfsp-spirit
Copy link
Collaborator

Author Guidelines

  • Is the change set < 600 lines?
  • Was the code checked for memory leaks/performance bottlenecks?
  • Is the code running locally and on the ESI cluster?
  • Is the code running on all supported platforms?

Reviewer Checklist

  • Are testing routines present?
  • Do parallel loops have a set length and correct termination conditions?
  • Do objects in the global package namespace perform proper parsing of their input?
  • Do code-blocks provide novel functionality, i.e., no re-factoring using builtin/external packages possible?
  • Code layout
    • Is the code PEP8 compliant?
    • Does the code adhere to agreed-upon naming conventions?
    • Are keywords clearly named and easy to understand?
    • No commented-out code?
  • Are all docstrings complete and accurate?
  • Is the CHANGELOG.md up to date?

a
Revert to 00a8437
@dfsp-spirit dfsp-spirit changed the base branch from master to dev September 14, 2022 12:40
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #350 (87be272) into dev (a16b4d5) will increase coverage by 0.13%.
The diff coverage is 79.05%.

@@            Coverage Diff             @@
##              dev     #350      +/-   ##
==========================================
+ Coverage   69.76%   69.89%   +0.13%     
==========================================
  Files          77       77              
  Lines        8946     9033      +87     
  Branches     1844     1878      +34     
==========================================
+ Hits         6241     6314      +73     
+ Misses       2284     2281       -3     
- Partials      421      438      +17     
Impacted Files Coverage Δ
syncopy/datatype/discrete_data.py 83.58% <ø> (-0.13%) ⬇️
syncopy/io/save_spy_container.py 71.32% <66.66%> (+0.20%) ⬆️
syncopy/datatype/methods/padding.py 70.38% <75.00%> (ø)
syncopy/datatype/base_data.py 82.73% <77.03%> (+0.46%) ⬆️
syncopy/io/load_spy_container.py 73.84% <83.33%> (+0.03%) ⬆️
syncopy/datatype/methods/copy.py 92.30% <94.11%> (+0.64%) ⬆️
syncopy/datatype/continuous_data.py 84.51% <100.00%> (+0.87%) ⬆️
syncopy/plotting/_helpers.py 84.48% <0.00%> (-8.63%) ⬇️
syncopy/plotting/mp_plotting.py 46.92% <0.00%> (-1.54%) ⬇️
syncopy/specest/compRoutines.py 90.81% <0.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dfsp-spirit dfsp-spirit marked this pull request as ready for review September 14, 2022 14:21
Copy link
Contributor

@tensionhead tensionhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this outstanding work @dfsp-spirit ! Now the diff looks much cleaner, and with the class attributes removed I think it is finally ready to merge 🚀

@tensionhead tensionhead merged commit 7f7f898 into dev Sep 14, 2022
@dfsp-spirit dfsp-spirit deleted the seq_stats_premerge branch September 21, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants