Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: prevent error on init of SpikeData with empty ndarray #317

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

dfsp-spirit
Copy link
Collaborator

@dfsp-spirit dfsp-spirit commented Jul 26, 2022

Miny PR, fixes #257

Author Guidelines

  • Is the change set < 600 lines?
  • Was the code checked for memory leaks/performance bottlenecks?
  • Is the code running locally and on the ESI cluster?
  • Is the code running on all supported platforms?

Reviewer Checklist

  • Are testing routines present?
  • Do parallel loops have a set length and correct termination conditions?
  • Do objects in the global package namespace perform proper parsing of their input?
  • Do code-blocks provide novel functionality, i.e., no re-factoring using builtin/external packages possible?
  • Code layout
    • Is the code PEP8 compliant?
    • Does the code adhere to agreed-upon naming conventions?
    • Are keywords clearly named and easy to understand?
    • No commented-out code?
  • Are all docstrings complete and accurate?
  • Is the CHANGELOG.md up to date?

@dfsp-spirit dfsp-spirit requested a review from tensionhead July 26, 2022 09:51
@dfsp-spirit dfsp-spirit self-assigned this Jul 26, 2022
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #317 (6a4a85a) into dev (ee9aa59) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #317      +/-   ##
==========================================
+ Coverage   72.58%   72.66%   +0.07%     
==========================================
  Files          72       72              
  Lines        7931     7931              
  Branches     1612     1612              
==========================================
+ Hits         5757     5763       +6     
+ Misses       1782     1779       -3     
+ Partials      392      389       -3     
Impacted Files Coverage Δ
syncopy/datatype/discrete_data.py 83.33% <100.00%> (ø)
syncopy/datatype/base_data.py 82.47% <0.00%> (+0.20%) ⬆️
syncopy/shared/computational_routine.py 82.50% <0.00%> (+0.55%) ⬆️
syncopy/shared/tools.py 76.56% <0.00%> (+3.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee9aa59...6a4a85a. Read the comment docs.

@tensionhead
Copy link
Contributor

Thx for fixing this @dfsp-spirit !

@tensionhead tensionhead merged commit e41e8fe into dev Jul 26, 2022
@tensionhead tensionhead deleted the 257_fix_error_message_empty_spikedata branch July 26, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants