140 multiple outputs #311
Merged
140 multiple outputs #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- first ideas how to attach additional data to the hdf5 On branch 140-multiple-outputs Changes to be committed: modified: syncopy/shared/kwarg_decorators.py
On branch 140-multiple-outputs Changes to be committed: modified: syncopy/shared/kwarg_decorators.py
- all h5py reading and writing should be done within this decorator - already the case for parallel processing - TODO: move sequential part also into this decorator Changes to be committed: modified: syncopy/datatype/methods/arithmetic.py modified: syncopy/datatype/methods/padding.py modified: syncopy/datatype/methods/selectdata.py modified: syncopy/nwanalysis/AV_compRoutines.py modified: syncopy/nwanalysis/ST_compRoutines.py modified: syncopy/preproc/compRoutines.py modified: syncopy/shared/computational_routine.py modified: syncopy/shared/kwarg_decorators.py modified: syncopy/specest/compRoutines.py modified: syncopy/tests/test_computationalroutine.py
- removed the comment-like return value Changes to be committed: modified: syncopy/shared/kwarg_decorators.py
Changes to be committed: modified: syncopy/specest/compRoutines.py modified: syncopy/tests/local_spy.py
140 sub remove hdr memmap
- now it's a pretty line break Changes to be committed: modified: syncopy/shared/computational_routine.py
|
As the removed memmap support never was exposed to the user (afaik), I think we don't need any changelog entry |
Changes to be committed: modified: syncopy/io/save_spy_container.py
Codecov Report
@@ Coverage Diff @@
## dev #311 +/- ##
==========================================
+ Coverage 72.36% 72.42% +0.06%
==========================================
Files 68 68
Lines 7904 7704 -200
Branches 1629 1581 -48
==========================================
- Hits 5720 5580 -140
+ Misses 1787 1744 -43
+ Partials 397 380 -17
Continue to review full report at Codecov.
|
|
This got already reviewed as a sub branch, passing tests are enough for me here! Thx @dfsp-spirit for leading the way for streamlining the CRs :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Despite the name, this does NOT implement multiple outputs for compute functions. It is only a step in that direction, and removes the hdr/memmap support.
Author Guidelines
Reviewer Checklist