Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single trial corr bug #446

Closed
tensionhead opened this issue Mar 2, 2023 · 0 comments
Closed

Single trial corr bug #446

tensionhead opened this issue Mar 2, 2023 · 0 comments
Assignees
@tensionhead
Labels
Bug An error that is serious but does not break (parts of) the package. However, it clearly impedes the

Comments

@tensionhead
Copy link
Contributor

Something goes wrong with the trialdefinition for:

corr = spy.connectivityanalysis(adata, method='corr', keeptrials=True)

when there is an odd number of samples..
@tensionhead tensionhead added the Bug An error that is serious but does not break (parts of) the package. However, it clearly impedes the label Mar 2, 2023
@tensionhead tensionhead self-assigned this Mar 2, 2023
tensionhead added a commit that referenced this issue Mar 2, 2023
@tensionhead
FIX: Correct trialdefinition for odd sample numbers
2ab0c79 
- the original solution was too simple to be true
- fixes #446

On branch fix-corr
Changes to be committed:
	modified:   syncopy/connectivity/ST_compRoutines.py
	modified:   syncopy/tests/test_connectivity.py
@tensionhead tensionhead mentioned this issue Mar 2, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tensionhead tensionhead

Labels
Bug An error that is serious but does not break (parts of) the package. However, it clearly impedes the
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tensionhead