We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug In-place selections in Syncopy data objects silently wiped by unwrap_select()
unwrap_select()
To Reproduce Given a syncopy data object data, (e.g. AnalogData instance) the following should be equivalent:
data
AnalogData
cfg = get_default_cf() # whatever selected_trials = [3, 5, 7] cfg.select = { 'trials': selected_trials } # Select option 1 spy.selectdata(data, trials=selected_trials, inplace=True) # Select option 2 freqanalysis(cfg, data)
but calling freqanalysis with the data, the 2nd slection is ignored and the function works on all trials.
freqanalysis
Expected behavior The selection gets honored by the cF function/frontend called, and it works on the 3 selected trials only.
Having a selection defined both as an in-place selection in data, and in the cfg, should lead to an error.
System Profile:
import syncopy as spy; spy.AnalogData().log
System Profile: 3.8.13 (default, Mar 28 2022, 11:38:47) [GCC 7.5.0] ACME: 2022.7 Dask: 2022.05.0 NumPy: 1.21.5 SciPy: 1.7.3 --- LOG --- |=== schaefert@esi-lbfri101: Wed Aug 10 14:44:22 2022 ===| __init__: created AnalogData object
Additional Information Please add any other context concerning the problem here.
Thank you again for your time!
The text was updated successfully, but these errors were encountered:
Merge pull request #346 from esi-neuroscience/332_inplace_sel
c98f186
332 inplace sel, fixes #332
Closing as done.
Sorry, something went wrong.
dfsp-spirit
Successfully merging a pull request may close this issue.
Describe the bug
In-place selections in Syncopy data objects silently wiped by
unwrap_select()
To Reproduce
Given a syncopy data object
data
, (e.g.AnalogData
instance) the following should be equivalent:but calling
freqanalysis
with the data, the 2nd slection is ignored and the function works on all trials.Expected behavior
The selection gets honored by the cF function/frontend called, and it works on the 3 selected trials only.
Having a selection defined both as an in-place selection in data, and in the cfg, should lead to an error.
System Profile:
Additional Information
Please add any other context concerning the problem here.
Thank you again for your time!
The text was updated successfully, but these errors were encountered: