Пронин И.П. 381806-1 #36
Conversation
| std::string str = ("static_cast<" + DestTypeString + ">").str(); | ||
| const Expr *SubExpr = Item->getSubExprAsWritten()->IgnoreImpCasts(); | ||
|
|
||
| if(!isa<ParenExpr>(SubExpr)) { |
There was a problem hiding this comment.
What does this check mean? Please describe examples of when this check returns true and when this check returns false.
There was a problem hiding this comment.
Эта проверка возвращает true или false в зависимости от того, заключено ли текущее выражение в скобки. Пример: int a = (int)f - true; int a = (int)(f) - false.
|
|
||
| void run(const MatchFinder::MatchResult &Result) override { | ||
| // Your code goes here | ||
|
|
||
| const auto *Item = Result.Nodes.getNodeAs<CStyleCastExpr>("cast"); |
There was a problem hiding this comment.
What if Item is a null pointer? How to protect the program from crashing in such cases?
There was a problem hiding this comment.
Как вариант дописать такую проверку:
if (Item == nullptr)
return;
| SourceM, | ||
| Result.Context->getLangOpts()); | ||
|
|
||
| std::string str = ("static_cast<" + DestTypeString + ">").str(); |
There was a problem hiding this comment.
Why is .str() used here? What happens if we get rid of .str() call?
There was a problem hiding this comment.
Эта функция нужна чтобы вписать type в строку static_cast.
| Item->getSubExprAsWritten()->getBeginLoc()); | ||
|
|
||
| StringRef DestTypeString = | ||
| Lexer::getSourceText(CharSourceRange::getTokenRange(Item->getLParenLoc().getLocWithOffset(1), |
There was a problem hiding this comment.
Please describe why you are using getTokenRange() here.
What is the difference between the getTokenRange() and the getCharRange() method?
There was a problem hiding this comment.
getTokenRange() - возвращает диапазон токенов до начала последнего токена
getCharRange() - возвращает диапазон символов до последнего символа включительно
Допустимо использование обоих вариантов, просто аргументы функций будут различны.
| CastCallBack(Rewriter& rewriter) { | ||
| // Your code goes here | ||
| }; | ||
| CastCallBack(Rewriter& rewriter) : rewriter_(rewriter) { }; |
There was a problem hiding this comment.
Нет, можно обойтись и без ; потому что ; находится в конце блока.
No description provided.