Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transaction status #88

Merged
merged 14 commits into from
Apr 8, 2018
Merged

Add transaction status #88

merged 14 commits into from
Apr 8, 2018

Conversation

eshaham
Copy link
Owner

@eshaham eshaham commented Mar 7, 2018

Adds either a completed or a pending status field to all transactions

closes #57

@eshaham
Copy link
Owner Author

eshaham commented Mar 7, 2018

@asfktz please go over before I merge 😄

@asfktz
Copy link
Contributor

asfktz commented Mar 10, 2018

Hi @eshaham, nice!
I will soon

@eshaham
Copy link
Owner Author

eshaham commented Mar 18, 2018

@esakal can you add transaction status to Leumi scraper as well?

@esakal
Copy link
Collaborator

esakal commented Mar 18, 2018

@eshaham sure I will check this out

@asfktz
Copy link
Contributor

asfktz commented Mar 22, 2018

@eshaham looks good to me (:

@eshaham
Copy link
Owner Author

eshaham commented Mar 27, 2018

@esakal did you get a chance to take a look?

@esakal
Copy link
Collaborator

esakal commented Mar 27, 2018

Hi @eshaham, Actually I didn't I was working on eshaham/israeli-ynab-updater#32 which consumed most of my time (which I dedicate to open-sources) in the last two weeks. Hopefully I will be able to check it later this week.

@esakal
Copy link
Collaborator

esakal commented Mar 27, 2018

@eshaham can you please merge master into this branch. It doesn't seems to include the bank leumi scraper

@esakal
Copy link
Collaborator

esakal commented Mar 31, 2018

@eshaham I'm not sure what should I do to get pending transactions. I was entering my account several times during the week and the weekend without success.

Do you know when a pending transaction is being created?

@eshaham
Copy link
Owner Author

eshaham commented Apr 1, 2018

@esakal it is usually created when the bank has knowledge of a future transaction. The most common use case is when you have credit cards under your bank account, and the bank shows a future pending transaction for the monthly charge. They may appear under a separate menu item in your checking account. If you don't see these under your account, maybe Leumi doesn't have them listed??

@ifeins, can you check in your account?

@asfktz
Copy link
Contributor

asfktz commented Apr 1, 2018

@eshaham, In Bank Hapoalim, it looks something like this:

35408496-ffbbd098-0217-11e8-9a99-217d635caf47

@esakal
Copy link
Collaborator

esakal commented Apr 1, 2018

@asfktz @eshaham thanks, I understand it should appear around the credit card payments. I will try to access it tomorrow hopefully to see something similar

@esakal
Copy link
Collaborator

esakal commented Apr 2, 2018

@eshaham can you please merge master to this branch because Leumi scraper is not there yet

Let me know if you want that I will merge master into this branch

@eshaham
Copy link
Owner Author

eshaham commented Apr 2, 2018

@esakal done

@esakal
Copy link
Collaborator

esakal commented Apr 2, 2018

@eshaham please review #107

@eshaham
Copy link
Owner Author

eshaham commented Apr 2, 2018

@esakal done. Thanks!!

@eshaham eshaham merged commit ecdf977 into master Apr 8, 2018
@eshaham eshaham deleted the txn_status branch April 8, 2018 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status property
4 participants