-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transaction status #88
Conversation
Add status property to Bank Hapoalim
Add pending transactions to Discount scraper
@asfktz please go over before I merge 😄 |
Hi @eshaham, nice! |
@esakal can you add transaction status to Leumi scraper as well? |
@eshaham sure I will check this out |
@eshaham looks good to me (: |
@esakal did you get a chance to take a look? |
Hi @eshaham, Actually I didn't I was working on eshaham/israeli-ynab-updater#32 which consumed most of my time (which I dedicate to open-sources) in the last two weeks. Hopefully I will be able to check it later this week. |
@eshaham can you please merge master into this branch. It doesn't seems to include the bank leumi scraper |
@eshaham I'm not sure what should I do to get pending transactions. I was entering my account several times during the week and the weekend without success. Do you know when a pending transaction is being created? |
@esakal it is usually created when the bank has knowledge of a future transaction. The most common use case is when you have credit cards under your bank account, and the bank shows a future pending transaction for the monthly charge. They may appear under a separate menu item in your checking account. If you don't see these under your account, maybe Leumi doesn't have them listed?? @ifeins, can you check in your account? |
@eshaham, In Bank Hapoalim, it looks something like this: |
@esakal done |
@esakal done. Thanks!! |
add status property to bank leumi scraper
Adds either a
completed
or apending
status field to all transactionscloses #57