Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change github to gitlab in section 4 #5

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Change github to gitlab in section 4 #5

merged 3 commits into from
Nov 18, 2024

Conversation

svenvanderburg
Copy link

No description provided.

carschno
carschno approved these changes Nov 16, 2024
View reviewed changes
Copy link

@carschno carschno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Added one suggestion.

  • Update reference to a pull request.

_episodes/41-code-review.md Outdated Show resolved Hide resolved
sjvrijn
sjvrijn approved these changes Nov 18, 2024
View reviewed changes
Copy link

@sjvrijn sjvrijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more suggestion by me, looks good after that!

svenvanderburg and others added 2 commits November 18, 2024 11:21
@svenvanderburg @carschno
Fix old reference to pull request
240178d 
Co-authored-by: Carsten Schnober <[email protected]>
@svenvanderburg @sjvrijn
Replace reference to PR with MR
ba4adae 
Co-authored-by: Sander van Rijn <[email protected]>
@svenvanderburg
Copy link
Author

Thanks @sjvrijn and @carschno for spotting the leftovers, this will save some confusion during the workshop!

@svenvanderburg svenvanderburg merged commit 24e646d into gh-pages Nov 18, 2024
@svenvanderburg svenvanderburg deleted the github2gitlab-section4 branch November 18, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjvrijn sjvrijn sjvrijn approved these changes

@carschno carschno carschno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svenvanderburg @carschno @sjvrijn