Eschweitzer78/issue 280 (#282)

* NSW DS LWR update * Versions * css and osfilegen for NSW DS * removing logs * NSW DS added back to top to theme * prettier * 2 Jan additions * Upgrade of prettier to v3 * New prettier rules * NSW DS Media correction * fix issue 280 * Notice re standard runtime
eschweitzer78 · Jan 8, 2024 · e718548 · e718548
1 parent 5acf0a6
commit e718548
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 8 deletions.
diff --git a/README.md b/README.md
@@ -5,7 +5,7 @@
 A collection of Salesforce Lightning Web Components (LWCs) for selected Governments' Design Systems. The collection
 covers Salesforce Experience Cloud as well as Salesforce Communities for Public Sector Solutions (Omnistudio), and may be extended in the future to help with Salesforce Flows provided they're surfaced via an Experience Cloud community.
 
-Note that at this stage there is a dependency on Omnistudio **246.10 (at the minimum)**, which is the version we tested against.
+Note that at this stage there is a dependency on Omnistudio **246.10 (at the minimum)**, which is the version we tested against. You also need to stay on the Omnistudio Managed Package runtime as the standard runtime is not quite on parity yet when it comes to overrides, which we do leverage quite a bit.
 
 Do read our [change log](./CHANGELOG.md) if you plan on updating already installed packages in order to check for changes in behaviour or configuration changes.
 

diff --git a/sfGpsDsAuNsw/main/default/lwc/sfGpsDsAuNswComboboxOsN/sfGpsDsAuNswComboboxOsN.html b/sfGpsDsAuNsw/main/default/lwc/sfGpsDsAuNswComboboxOsN/sfGpsDsAuNswComboboxOsN.html
@@ -23,6 +23,7 @@
             class="sfgpsds-combobox sfgpsds-dropdown-trigger sfgpsds-dropdown-trigger_click"
           >
             <div class="sfgpsds-combobox__form-element" role="none">
+              <!-- issue #280: add onclick event handler on input for omnistudio 248 -->
               <input
                 class="nsw-form__input sfgpsds-combobox__input combobox"
                 aria-describedby={computedAriaDescribedBy}
@@ -44,6 +45,7 @@
                 value={valueCopy}
                 onblur={showLookup}
                 onmouseup={showLookup}
+                onclick={showLookup}
                 onkeydown={preventKeyDown}
                 onkeyup={handleKeyUp}
               />

diff --git a/sfGpsDsAuNswS/main/default/lwc/sfGpsDsAuNswSComboboxOsN/sfGpsDsAuNswSComboboxOsN.html b/sfGpsDsAuNswS/main/default/lwc/sfGpsDsAuNswSComboboxOsN/sfGpsDsAuNswSComboboxOsN.html
@@ -25,6 +25,7 @@
             class="sfgpsds-combobox sfgpsds-dropdown-trigger sfgpsds-dropdown-trigger_click"
           >
             <div class="sfgpsds-combobox__form-element" role="none">
+              <!-- issue #280: add onclick event handler on input for omnistudio 248 -->
               <input
                 class="form__input sfgpsds-combobox__input combobox"
                 aria-describedby={computedAriaDescribedBy}
@@ -46,6 +47,7 @@
                 value={valueCopy}
                 onblur={showLookup}
                 onmouseup={showLookup}
+                onclick={showLookup}
                 onkeydown={preventKeyDown}
                 onkeyup={handleKeyUp}
               />

diff --git a/sfGpsDsAuVic/main/default/lwc/sfGpsDsAuVicComboboxOsN/sfGpsDsAuVicComboboxOsN.html b/sfGpsDsAuVic/main/default/lwc/sfGpsDsAuVicComboboxOsN/sfGpsDsAuVicComboboxOsN.html
@@ -23,6 +23,7 @@
                 class="sfgpsds-combobox sfgpsds-dropdown-trigger sfgpsds-dropdown-trigger_click"
               >
                 <div class="sfgpsds-combobox__form-element" role="none">
+                  <!-- issue #280: add onclick event handler on input for omnistudio 248 -->
                   <input
                     class="sfgpsds-input sfgpsds-combobox__input combobox"
                     aria-describedby={computedAriaDescribedBy}
@@ -44,6 +45,7 @@
                     value={valueCopy}
                     onblur={showLookup}
                     onmouseup={showLookup}
+                    onclick={showLookup}
                     onkeydown={preventKeyDown}
                     onkeyup={handleKeyUp}
                   />

diff --git a/sfdx-project.json b/sfdx-project.json
@@ -11,8 +11,8 @@
     {
       "path": "sfGpsDsAuNswFull",
       "package": "Salesforce Global Public Sector AU NSW Design System",
-      "versionName": "2024.01.02.1800",
-      "versionNumber": "2.3.4.NEXT",
+      "versionName": "2024.01.08.1630",
+      "versionNumber": "2.3.5.NEXT",
       "default": false,
       "definitionFile": "config/project-deployment-def.json",
       "dependencies": [
@@ -29,8 +29,8 @@
     {
       "path": "sfGpsDsAuNswSFull",
       "package": "Salesforce Global Public Sector AU NSW Service Design System",
-      "versionName": "2024.01.02.1800",
-      "versionNumber": "2.3.4.NEXT",
+      "versionName": "2024.01.08.1630",
+      "versionNumber": "2.3.5.NEXT",
       "default": false,
       "versionDescription": "Salesforce Global Public Sector AU Service NSW Design System (Full)",
       "dependencies": [
@@ -45,8 +45,8 @@
     {
       "path": "sfGpsDsAuVic1Full",
       "package": "Salesforce Global Public Sector AU VIC Design System",
-      "versionName": "2024.01.02.1800",
-      "versionNumber": "2.3.4.NEXT",
+      "versionName": "2024.01.08.1630",
+      "versionNumber": "2.3.5.NEXT",
       "default": false,
       "versionDescription": "Salesforce Global Public Sector AU VIC Design System v1 (Full)",
       "dependencies": [
@@ -62,7 +62,7 @@
     {
       "path": "sfGpsDsAuVic2Full",
       "package": "Salesforce Global Public Sector AU VIC Design System v2",
-      "versionName": "2023.11.29.1630",
+      "versionName": "2024.01.08.1630",
       "versionNumber": "0.1.1.NEXT",
       "default": false,
       "definitionFile": "config/project-deployment-def.json",