Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ifelse to select. #29

Closed

Conversation

GunnarFarneback
Copy link
Contributor

This attempts to solve #28 by renaming ifelse to select. Note that Base.select is deprecated for Julia 0.7 and expected to be removed for 1.0.

@eschnett
Copy link
Owner

I noticed that select in OpenCL takes the arguments in reverse order: ifelse(a,b,c) corresponds to select(c,b,a). I've thus experimented with a new function vifelse since I didn't have any better idea.

Do you think the difference in argument order is confusing?

@GunnarFarneback
Copy link
Contributor Author

No opinion really about name or argument order. I've never used select in OpenCL, nor ifelse in SIMD.jl. All I want is to get the package working on 0.7 so I can run my code there. :-)

@eschnett
Copy link
Owner

Well, since you did the work, let's go with select then.

Do you know why Travis fails on the nightly build? That's a weird error message (and doesn't seem related to this issue here, so we can also ignore it.)

@GunnarFarneback
Copy link
Contributor Author

No idea about what's up with Travis. If I run the same commands on my Linux computer (with a marginally newer Julia) it passes.

@codecov-io
Copy link

codecov-io commented Jun 16, 2018

Codecov Report

Merging #29 into master will increase coverage by 0.61%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   90.19%   90.81%   +0.61%     
==========================================
  Files           1        1              
  Lines         663      664       +1     
==========================================
+ Hits          598      603       +5     
+ Misses         65       61       -4
Impacted Files Coverage Δ
src/SIMD.jl 90.81% <100%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 164d7b7...4f898f3. Read the comment docs.

@GunnarFarneback
Copy link
Contributor Author

Note, the Julia 1.0 forward compatibility is incomplete; there are additional Base.select definitions later in the code.

@eschnett
Copy link
Owner

I have pushed the other branch instead which uses vifelse as new name.

@eschnett eschnett closed this Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants