-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ifelse to select. #29
Conversation
I noticed that Do you think the difference in argument order is confusing? |
No opinion really about name or argument order. I've never used |
Well, since you did the work, let's go with Do you know why Travis fails on the nightly build? That's a weird error message (and doesn't seem related to this issue here, so we can also ignore it.) |
No idea about what's up with Travis. If I run the same commands on my Linux computer (with a marginally newer Julia) it passes. |
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
+ Coverage 90.19% 90.81% +0.61%
==========================================
Files 1 1
Lines 663 664 +1
==========================================
+ Hits 598 603 +5
+ Misses 65 61 -4
Continue to review full report at Codecov.
|
Note, the Julia 1.0 forward compatibility is incomplete; there are additional Base.select definitions later in the code. |
I have pushed the other branch instead which uses |
This attempts to solve #28 by renaming
ifelse
toselect
. Note thatBase.select
is deprecated for Julia 0.7 and expected to be removed for 1.0.