-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cocktail card - save to image #7
Conversation
You can run |
src/components/story/ButtonSet.tsx
Outdated
return ( | ||
<div | ||
id="buttonSet" | ||
className="relative mx-auto my-auto mt-2 flex w-[16rem] gap-4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please avoid arbitrary value
className="relative mx-auto my-auto mt-2 flex w-[16rem] gap-4" | |
className="relative mx-auto my-auto mt-2 flex w-64 gap-4" | |
Do you have any suggestion on formatting? I think what cause the issue is the text inside Before running However, after running ![]() ![]() |
It's actually not a great idea to separate lines like that. Please use |
Thank you for your comment kub. Sorry for my frequent commits and pushes, I run Another thing is that I just realized that I could run |
<div className="absolute inset-x-0 -left-[1.25rem] bottom-32 opacity-80"> | ||
<img | ||
className="absolute left-0 top-[48px] h-32 w-[152px]" | ||
src="/src/images/elements/calendar.png" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please import it first as
import Calendar from "@/assets/images/elements/calendar.png"
// then
<img ... src={Calendar.src} ... />
Since Card pages have the same layout, is it possible to create a shared layout or shared components for them? |
Furthermore, the assets are already located in the |
…into worranittha/gea-18-save-to-image
…into worranittha/gea-18-save-to-image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Change made
Describe what you have done
New Features