Fix broken validation and multiple custom #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n on the same property
| @@ -37,7 +37,8 @@ export default Ember.Mixin.create({ | |||
| if(Object.keys(errors).length !== 0){ | |||
| var stateToTransition = this.get('isNew') ? 'created.uncommitted' : 'updated.uncommitted'; | |||
| this.transitionTo(stateToTransition); | |||
| store.recordWasInvalid(this, errors); | |||
| var recordModel = this.adapterDidInvalidate ? this : this._internalModel; | |||
There was a problem hiding this comment.
This fixes the errors with 1.13.x and allows for current uses to still work. @esbanarango
|
@davidstevens37 Thank you very much for your work!! I review and merge this weekend. |
|
@esbanarango no problem, let me know if there is anything you think should be changed. |
|
@esbanarango is there anything in here you think should changed or is wrong? |
esbanarango
added a commit
that referenced
this pull request
Jul 29, 2015
…multiple-custom Fix broken validation and multiple custom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created the ability pass an array of custom validations if needed.
Upgraded ember-cli, ember, and ember data so that the model validator will work on the newest release.