Fix memory leak (#344)

* Refactor launcher

* fix memory leak in image picker and sample app

gradle.properties

@@ -16,5 +16,4 @@
 # This option should only be used with decoupled projects. More details, visit
 # http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects
 # org.gradle.parallel=true
-android.enableJetifier=true
 android.useAndroidX=true

imagepicker/src/main/java/com/esafirm/imagepicker/features/ContentObserverTrigger.kt

@@ -21,6 +21,7 @@ class ContentObserverTrigger(
             Lifecycle.Event.ON_CREATE -> onCreate()
             Lifecycle.Event.ON_DESTROY -> onDestroy()
             else -> {
+                // Ignore others event
             }
         }
     }
@@ -30,7 +31,7 @@ class ContentObserverTrigger(
             handler = Handler()
         }
 
-        val contentObserver = object : ContentObserver(handler) {
+        observer = object : ContentObserver(handler) {
             override fun onChange(selfChange: Boolean) {
                 loadData()
             }
@@ -39,7 +40,7 @@ class ContentObserverTrigger(
         contentResolver.registerContentObserver(
             MediaStore.Images.Media.EXTERNAL_CONTENT_URI,
             false,
-            contentObserver
+            observer!!
         )
     }
 

imagepicker/src/main/java/com/esafirm/imagepicker/features/ImagePickerComponentsHolder.kt

@@ -16,7 +16,7 @@ interface ImagePickerComponents {
 
 open class DefaultImagePickerComponents(context: Context) : ImagePickerComponents {
     override val imageLoader: ImageLoader by lazy { DefaultImageLoader() }
-    override val imageFileLoader: ImageFileLoader by lazy { DefaultImageFileLoader(context) }
+    override val imageFileLoader: ImageFileLoader by lazy { DefaultImageFileLoader(context.applicationContext) }
     override val cameraModule: CameraModule by lazy { DefaultCameraModule() }
 }
 

imagepicker/src/main/java/com/esafirm/imagepicker/model/Image.kt

@@ -9,7 +9,7 @@ import kotlinx.android.parcel.IgnoredOnParcel
 import kotlinx.android.parcel.Parcelize
 
 @Parcelize
-open class Image(
+class Image(
     val id: Long,
     val name: String,
     val path: String,

sample/build.gradle

@@ -45,8 +45,7 @@ dependencies {
     /* Development */
     implementation project(':imagepicker')
 
-    debugImplementation 'com.squareup.leakcanary:leakcanary-android:1.6.2'
-    debugImplementation 'com.squareup.leakcanary:leakcanary-support-fragment:1.6.2'
+    debugImplementation 'com.squareup.leakcanary:leakcanary-android:2.6'
     implementation "androidx.core:core-ktx:$core_ktx_version"
 
     /* UI Test */

sample/src/main/AndroidManifest.xml

@@ -3,7 +3,6 @@
     package="com.esafirm.sample">
 
     <application
-        android:name=".SampleApplication"
         android:allowBackup="true"
         android:icon="@mipmap/ic_launcher"
         android:label="@string/app_name"

sample/src/main/java/com/esafirm/sample/CustomImagePickerComponents.kt

@@ -0,0 +1,18 @@
+package com.esafirm.sample
+
+import android.content.Context
+import com.esafirm.imagepicker.features.DefaultImagePickerComponents
+import com.esafirm.imagepicker.features.imageloader.DefaultImageLoader
+import com.esafirm.imagepicker.features.imageloader.ImageLoader
+
+class CustomImagePickerComponents(
+    context: Context,
+    private val useCustomImageLoader: Boolean
+) : DefaultImagePickerComponents(context.applicationContext) {
+    override val imageLoader: ImageLoader
+        get() = if (useCustomImageLoader) {
+            GrayscaleImageLoader()
+        } else {
+            DefaultImageLoader()
+        }
+}

sample/src/main/java/com/esafirm/sample/MainActivity.kt

@@ -59,14 +59,9 @@ class MainActivity : AppCompatActivity() {
         val onlyVideo = binding.switchOnlyVideo.isChecked
         val isExclude = binding.switchIncludeExclude.isChecked
 
-        ImagePickerComponentsHolder.setInternalComponent(object : DefaultImagePickerComponents(this) {
-            override val imageLoader: ImageLoader
-                get() = if (useCustomImageLoader) {
-                    GrayscaleImageLoader()
-                } else {
-                    DefaultImageLoader()
-                }
-        })
+        ImagePickerComponentsHolder.setInternalComponent(
+            CustomImagePickerComponents(this, useCustomImageLoader)
+        )
 
         return ImagePickerConfig {