-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README.md expand import examples #6
Conversation
It means that instead of forcing you to do, eg, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine, but if you're using node you need to be able to look at either CJS or ESM examples and implicitly understand how to convert one to the other.
Right, I mean I figured it out eventually what the require path was relative to, how to convert CJS to ESM and which module executed the shims automagically. But all three together were a bit many hurdles for my taste, hence this PR. I pushed two commits (to make CI pass and to fix the typo you mentioned), so now it's ready to merge I think. |
Removing evalmd is like deleting tests - the benefit of having an ESM example is much much smaller than the benefit of guaranteeing readme examples are correct. That said, i think evalmd has an html comment way to ignore specific code blocks, so that might work here. |
c634ca0
to
231f4db
Compare
Done... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
==========================================
- Coverage 89.71% 89.00% -0.71%
==========================================
Files 86 86
Lines 1011 1019 +8
Branches 135 127 -8
==========================================
Hits 907 907
- Misses 104 112 +8 ☔ View full report in Codecov by Sentry. |
Proposal to expanded the README to what I was looking for to get started. Feel free to change.
I was also not sure what this sentence means:
Does it relate to explicit imports instead of shimming or is it an implementation detail?